Bills: Annotate payment popup box gets skipped when using keyboard navigation to pay bills

Bug #2047158 reported by Susan Morrison
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fix Released
Fix Released
Fix Released

Bug Description

3.12 and likely earlier

When paying a bill using keyboard navigation, when the Annotate box is checked and you press Enter to apply the payment, the Annotate box pops up for a second but then closes, so the payment is applied without the ability to add a note.

description: updated
Steven Mayo (stmayo)
Changed in evergreen:
assignee: nobody → Steven Mayo (stmayo)
Revision history for this message
Steven Mayo (stmayo) wrote :

I've noticed that when this is happening the Annotate box stays popped up for as long as you hold down the enter key, and then submits immediately when you release it.

Revision history for this message
Steven Mayo (stmayo) wrote (last edit ):

This was due to silly conflict between use of keyup and keydown events. The modal was opening on a keydown, and submitting on keyup half a second later.
I've changed the modal to submit on keydown while entering text instead of keyup. Now you have to press the enter key a whole 'nother time. Branch here:;a=shortlog;h=refs/heads/user/smayo/lp2047158-Annotate_Payment_Modal_Skipped

Steps to test:
[1] Search for an account that owes money, or add a bill to an account
[2] Go to the patron's bills tab.
[3] Fill out the Pay Bill form using only the keyboard (tabs to change focus)
[4] Ensure that the Annotate checkbox is checked
[5] Press the enter key focused on the 'apply payment' button
[6] Observe

Changed in evergreen:
assignee: Steven Mayo (stmayo) → nobody
tags: added: pullrequest
Revision history for this message
Eva Cerninakova (ece) wrote :

I have tested this code using various patrons and payment types at I can confirm, that everything works as expected.

I consent to signing off on it with my name, Eva Cerniňáková and my email address, <email address hidden>.

Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
Revision history for this message
Terran McCanna (tmccanna) wrote :

Thanks Steven and Eva, fix pushed as far back as rel_3_11

Changed in evergreen:
status: New → Fix Committed
tags: added: signedoff
Changed in evergreen:
assignee: Terran McCanna (tmccanna) → nobody
milestone: none → 3.12.3
milestone: 3.12.3 → 3.13-beta
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.