Staff catalog facets "show less" has incorrect count

[Andrea Neiman]

3.12.0 ; 3.11.2

Follow up from bug 1934018.

The new staff catalog facets have a "Less" link to show fewer facets; however, when hovering over the "Less" link, the description is always "Show 5" even if there are fewer than 5 results

Similarly, the "More" link always displays even if there are not more options to be shown in the facets.

These links should be context aware, with counts, if possible.

[Stephanie Leary (stephanieleary)]

Here's a branch that hides the "more"/"less" button if the facet has 5 or fewer links: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/LP2046974-facet-more-link-count

[Galen Charlton (gmc)]

The test should be "> 5", not ">= 5", no? Otherwise the toggle still gets displayed if the facet happens to have exactly five entries.

[Stephanie Leary (stephanieleary)]

You are right; I second-guessed myself on that at the last minute for some reason. I've fixed that and squashed the fix into the same branch.

[Galen Charlton (gmc)]

Thanks! Tested and signed off: working/user/gmcharlt/lp2046974_signoff

[Bill Erickson (berick)]

Merged to main and 3.12.

I added 3.11 as a target to this bug but did not merge since there are merge conflicts with 3.11.

[Galen Charlton (gmc)]

I was comfortable with the merge conflict resolution, so I've gone ahead and pushed it to rel_3_11 as well.