Loading Pending Patrons Does Not Display Duplicate Field Value Alerts

[John Yorio]

3.10

When loading a patron from the pending patrons screen, there is no Address Alert unless you click into and out of one of the address fields.

As those fields may have been completed by the patron, there may be no need for staff to click into them. The unfortunate consequence is that staff are prevented from seeing the Address Alert.

It is true that this behavior also occurs whenever you view the patron's record, but the lack of an Address Alert may be less of an issue once the patron registration has been completed. I leave that up to discussion.

This sounds similar to, although not entirely the same as, https://bugs.launchpad.net/evergreen/+bug/1980273 My apologies if it is indeed a duplicate.

[Galen Charlton (gmc)]

Noting that this is _not_ the same as bug 1980273, which concerns the display of penalties/alerts in the patron summary tab in the AngularJS circulation interface.

Rather, it concerns the display of duplicate address warnings in the AngularJS patron editor. That interface currently runs the duplicate field value checks only when an input is (potentially) changed. It looks like that the desire is to also run these checks when the patron editor is loaded from a pending patron for the first time.

[Jason Boyer (jboyer)]

There's a branch at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp2046000_no_mo_multiplicity / working/user/jboyer/lp2046000_no_mo_multiplicity to enable this. It will check all of the fields that can be filled in on the self-registration page, even though some of them aren't present by default in the UI (or, like the requested username apparently can't be used currently.) It also checks the address for any alerts.

To test:
1. Pre patch, register a user with at least a first and last name, address, and if visible in your OPAC, phone and email fields.
2. Enable patron self-registration in Library Settings
3. Self-register a user with the same values used in (1)
4. Optionally, define an Address Alert for the address used in (1) (don't forget to enable it and set it for both types of address)
5. Load the pending patron, note that nothing happens (hence this bug)
6. Apply the patch and at least force-reload the client
7. Load the pending patron and this time you should see alerts that 1 user has the same name and address. Also, if you defined an address alert in (4) it should also appear.
8. Hurrah.

[Galen Charlton (gmc)]

Tested and signed off: user/gmcharlt/lp2046000_signoff

I also updated the patch to tidy whitespace.

[Elizabeth Davis (elidavis)]

Will this work for any address alert, or just the duplicate address alert?

[Jason Boyer (jboyer)]

Elizabeth, it also detects and displays regular Address Alerts if any apply to the pending patron. (Step 4 in the testing notes)

[Elizabeth Davis (elidavis)]

Thanks Jason! Eager to see this added to main.

[Terran McCanna (tmccanna)]

Thanks Jason & Galen!

Merged as far back as rel_3_12.