Angular Holdings Editor: Save only changed Call Number fields in Item Templates

[Michele Morgan]

Bug 1983156 (released in 3.12) restored the ability to save all call number attributes in item templates. The individual values, however (prefix, suffix, label class) should be stored only if they are changed by the user saving the template.

[Michele Morgan (mmorgan)]

Here's a branch that saves only the changed call number fields in the template :

user/mmorgan/LP2045989_only_save_changed_callnumber_fields

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/LP2045989_only_save_changed_callnumber_fields

Many thanks to Jane Sandberg for guidance!

[Jennifer Weston (jweston)]

Tested in Cataloging Interest Group -- confirmed functionality

Note: This works in Holdings Editor accessed via an Item Record (not in the Admin Holdings Editor Template interface)

Confirmed we see the template saved: Classification, Prefix, and Suffix

[Jennifer Weston (jweston)]

I have tested this code and consent to signing off on it with my name, Jennifer Weston, and behalf of the Cataloging Interest Group and my email address, <email address hidden>

[Galen Charlton (gmc)]

Upon testing this, I have a question about the desired behavior.

Consider this workflow:

[1] Create a template that sets the circulation modifier and the classification.
[2] Create a new item, and apply the template.
[3] Realize that you wanted to add more to the template, so you set the call number prefix and the age protection fields.
[4] Save the template, then export it.
[5] Here are the results:

- circ_lib and age_protect are set
- _only_ the prefix is set, not the classificaiton

Should it not retain the values of any (unchanged) call number fields taken from an original template when saving updates back to it?

[Jennifer Weston (jweston)]

Confirming behavior of editing the templates works as it has typically worked which involved a bit of a different workflow.
In the Holdings Editor,
[1] Choose option to add holdings
[2] Set desired template fields for shelving loc, classification, prefix & suffix and Save Template.
[3] Add Call Number Label and Barcode and Apply All, Save & Exit to create the item
[4] Realize that you wanted to add more to the template, so you reopen the item; add all desired template fields again by hand (not by applying previous template), set an additional field like the age protection field; selecting the same template name you want to update, choose Save Template.

Edited to add: Item Fields no longer have to be manually applied when editing a template - just applying the template works; the holdings fields now included in the templates are behaving differently but it does work with the manual update process

[Jennifer Weston (jweston)]

It would be nice if the Holdings Fields (classification, prefix, and suffix) turned green if they are changed when a template is applied -- like the item attributes