EDI: Stop using account when logging into FTP

[Jason Boyer]

Seen on Eg 3.11, but I suspect it's related to EDI vendors rather than Eg version.

The FTP protocol, ancient as it is, supports *3* pieces of login information: username, password, and account. Account isn't well specified and has likely been largely unused for its whole life, but now it's causing problems. We've seen at least one vendor that when trying to connect with all 3 pieces of information, the "526 ACCT unsupported" message returned causes RemoteAccount.pm to drop the connection and leaves EDI messages in the retry state. Removing the remote_account field from the ftp login in that perl module allows things to work as expected.

If anyone has any evidence that the account field is actually used by their vendor's FTP login process we can make its use optional at login, but I suspect if the field were just removed from the process altogether none would ever notice. (Note we do need to have the field for other reasons, such as building the actual EDI messages to upload.)

Branch implementing such coming soon.

[Jason Boyer (jboyer)]

Branch hereabouts: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp2045911_not_that_account / working/user/jboyer/lp2045911_not_that_account