Upgrade to nightwatch 3

Bug #2036312 reported by Jane Sandberg
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Committed
Undecided
Unassigned

Bug Description

It includes some convenient new selectors, and an interesting looking new Angular component integration: https://nightwatchjs.org/guide/overview/whats-new-in-v3.html

tags: added: angular
Revision history for this message
Jane Sandberg (sandbergja) wrote :

This turned out to be super easy -- just update package.json and run `npm i`.

Here is a branch: user/sandbergja/lp2036312-nightwatch3

Here is a link: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp2036312-nightwatch3

I'll note that the nightwatch tests previously wouldn't run on my Mac with Firefox 125.0.3; this branch gets them running again. On an Ubuntu focal container with Firefox 124.0.1, the nightwatch tests run both on main and on the current branch.

To test:
1. Load this commit onto a running Evergreen instance
2. cd Open-ILS/src/eg2
3. npm i
4. If you installed firefox using an Ubuntu snap: mkdir $HOME/tmp && export TMPDIR=$HOME/tmp
5. MOZ_HEADLESS=1 ng e2e

Expected behavior is that several tests run, some of which pass and some of which encounter errors (at least until bug 2058256 is resolved).

tags: added: pullrequest
Revision history for this message
Blake GH (bmagic) wrote :

Jane,

This branch includes changes to the package lock file. Are those needed?

Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks for taking a look, Blake. Yes, those are needed so that npm doesn't have to re-fetch the metadata for the various versions and recalculate package dependencies when you run `npm i`.

Revision history for this message
Blake GH (bmagic) wrote :

I re-read bug 1792394. That's a fun file :).

The patch does allow the nightwatch Firefox tests to function. Signed off and now on main. Thanks Jane!

Changed in evergreen:
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.