Hours of Operation Edit Note Field Check Boxes Don't Work Per Line

[Jennifer Pringle]

Evergreen 3.11.1

When editing hours of operation (Administration -> Server Administration -> Organizational Units) if you click the check box for Edit Note Field beside a particular day of the week the note field opens up for all 7 days. Only the day of the week selected should have the note field display.

This doesn't prevent the feature from being used but the display is confusing as it's not what you expect to happen when you click only one check box.

[Steven Mayo (stmayo)]

Got a fix for this out: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/smayo/lp2036296-Hours_of_Operation_Edit_Note_Check_Box_Per_Line

[Gina Monti (gmonti90)]

Works for me! Here's my signoff:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=abf5b2abdce62cef8b0549c097014873d503f9d4

[Galen Charlton (gmc)]

The form is not that large; is there any real reason not to just always display the notes field, either as an additional column or underneath the main time inputs for each row? That way, all of the information about the hours is displayed without the user having to fiddle with checkboxes.

[Terran McCanna (tmccanna)]

I like that idea, too. My only concern with it being always visible would be the inclination of some people to think they need to fill in every field they see. If we go that route, maybe add an "(optional)" or something along with the label to make sure it's clear?

[Galen Charlton (gmc)]

I've created a working branch with an alternative patch to always display the note field input: user/gmcharlt/lp2036296_always_show_dow_note / https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp2036296_always_show_dow_note

[Gina Monti (gmonti90)]

Here's my signoff, Galen:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmonti/lp2036296_always_show_dow_note_signoff

Looks good!