Create MARC Record - Non-Flat Editor - Keyboard Shortcuts

[Josh Stompro]

EG 3.11 - Trying to add a few extra keyboard shortcuts to the Create MARC Record editor.

Ctrl+s for save,
Ctrl+l for validate,
Ctrl+? for toggle help

Just trying to make it more keyboard only navigation friendly.

Breaking out the various chunks from bug #1862235, there was a commend from Mary Llewellyn about some of these not working. I'll try and work that out in this bug.
Josh

[Josh Stompro (u-launchpad-stompro-org)]

Ah, I think I see the problem. The scope of the keyboard shortcuts is only for when the focus/cursor is in the marc tag edit fields.

It doesn't work from anywhere else on the page.

Which makes sense for the shortcuts that have to do with editing the marc fields, but doesn't make sense for the things I added.

I'll try and fix things.
Josh

[Josh Stompro (u-launchpad-stompro-org)]

Working branch at user/stompro/lp2031188_create_marc_extra_keyboard_shortcuts

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp2031188_create_marc_extra_keyboard_shortcuts

I made a few other changes that seemed to make sense.

In the marc editor help, changed the documentation for the hotkeys to use uppercase. It was hard to read ctrl+l and ctrl+i and ctrl+I in the font that is used.

Changed to using ctrl+/ for help instead of ctrl+?. I couldn't get ctrl+? to work in (chieffancypants
/ angular-hotkeys) for some reason.

These work both when the focus is in and out of the marcedit section.

Testing Notes:

Try out the shortcuts in the create marc record interface.
Ctrl+s for save,
Ctrl+l for validate,
Ctrl+/ for toggle help

This does trigger bug 1862230, but I don't think that should hold this up.

Josh

[Beth Willis (willis-a)]

Tested on Terran's test server

In the Create New MARC Record interface I found that:

-- The CTRL+S command does save the new record, regardless of which area of the interface the cursor is in when this command is selected.

-- CTRL+L did validate the appropriate headings fields (e.g. 100, 650, 655), but not always. I was getting inconsistent results here. However, this may be related to the validate function and not to the new keyboard shortcut. **It would be great if others could test this shortcut.**

-- CTRL+/  does toggle the help screen, regardless of which area of the interface the cursor is in.  Note: CTRL+? also toggles the help screen when the cursor is in the main editing area.

BUT, in the main editor area, CTRL+/ (and CTRL+?) works only when the cursor is on a MARC field and not when the cursor is on MARC tag, on an indicator or on a subfield indicator (e.g. ‡a)

[Josh Stompro (u-launchpad-stompro-org)]

   BUT, in the main editor area, CTRL+/ (and CTRL+?) works only when the cursor is on a MARC field and not
   when the cursor is on MARC tag, on an indicator or on a subfield indicator (e.g. ‡a)

I'm trying to figure out why it doesn't work for the MARC tag, Indicators or subfield codes. There is something I'm not getting. The value that the help Div watches does get changed. !showHelp toggles between true and false. But it is like it won't redraw, or detect that it has changed? Any javascript experts know how to force the screen to redraw based on a variable changing?

Josh