Acq PO Activatable Message Incorrect When Multiple Messages are Relevant.

[Lena Hernandez]

Working in Evergreen 3.9 Acquisitions Module, on Chrome.

A pending PO says in the Activatable field "Yes; fund EH-9113 (2024) would be encumbered beyond its warning level," but when you click on the "activate order without loading items" button, you receive a message "Event:10004:ACQLINEITEM NOPRICE."

There are indeed line items that need prices and therefor the PO should not be activatable. On other POs, the activatable indicator has not changed to "yes" until after all line item prices and funds are added (behavior as expected). The issue seems to be the inclusion of the over-encumbrance alert, which is taking precedence over the assessment that all required fields are filled.

[Galen Charlton (gmc)]

Confirmed, and noting that there's an analogous issue with the Angular PO interface. In other words, this doesn't affect just the Dojo interface screen-shotted in the original bug report.

The cause of the problem is a quirk in open-ils.acq.purchase_order.activate.dry_run. When it does a dry run of creating fund debits, it stops at the first instance where an event is thrown. However, if that first event is just the fund exceeds balance warning event, it doesn't go any further to try to identify a condition that would make it impossible to activate the PO at all.

[Stephanie Leary (stephanieleary)]

It's an accessibility problem to ask users to cycle through all the errors one by one. We need to create a summary box at the top of the screen (outside the details panel) that lists all the errors found in the dry run, and each error should be linked to the relevant line item. Within each line item, the problem should be highlighted as an error.

The Gov.UK component library has an error summary example that demonstrates what we need to do here: https://design-system.service.gov.uk/components/error-summary/