Enhanced Concerto dataset (Cont.)
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Low
|
Unassigned | ||
3.11 |
Fix Released
|
Low
|
Unassigned | ||
3.12 |
Fix Released
|
Low
|
Unassigned |
Bug Description
Continuing bug 1901932
copy/paste from the last comment:
I promptly edited this code based upon the feedback.
Highlights:
- A date carry forward feature that carry's the various date columns forward based upon the difference between today's date and the create_date for asset.call_number in the dataset. Which is the default. This can be skipped with with: psql -v skip_date_carry='1' -f load_all.sql
- Expansion of special cases for certain tables: config.
- Dropping these tables from consideration: acq.acq_
I couldn't think of a good way to deal with the timezone issue. My first thought was to check the column for timezonetz and emit the data onto the disk without the timezone (-06). It seems, though, that the dates land in the database OK. And with the date carry forward business, the result looks sound. The drawback is git churn when the dataset is upgraded through versions of Evergreen. It looks* like the files change because they were restored to your local database, then dumped out again.
On a timezone unrelated note:
Working on this may have revealed an issue with some of our config.
opac.did_
opac.did_
search.
search.
search.
search.
Therefore, the enhanced concerto set, today, includes them.
I've created a new branch, since this branch was merged already.
tags: | added: pullrequest |
Changed in evergreen: | |
status: | New → Confirmed |
importance: | Undecided → Low |
assignee: | nobody → Jason Stephenson (jstephenson) |
milestone: | none → 3.12-beta |
Changed in evergreen: | |
milestone: | 3.12-beta → 3.next |
Changed in evergreen: | |
milestone: | 3.next → 3.13-beta |
status: | Fix Committed → Fix Released |
Re those six OU settings, they were deprecated in bug 1997485 and no longer included in new installs, but not fully removed (on the theory that an Evergreen admin may want to refer to their old values before fully committing to the new search class versions of those settings.
Consequently, they don't need to be in Enhanced Concerto, and I'll open a separate bug for their outright removal.