staff portal page add sort order to grid columns configuration

Bug #2021755 reported by Lindsay Stratton
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
New
Undecided
Unassigned

Bug Description

The staff portal grid > Manage Columns > Grid Columns Configuration lacks Sort Priority similar. Other grids, for example, Holds Pull List, includes sort priority.

This would be particularly helpful in the portal page configuration to keep track of page columns and columns order in particular.

tags: added: wishlist
tags: added: admin-pages eg-grid
Changed in evergreen:
assignee: nobody → Stephanie Leary (stephanieleary)
Revision history for this message
Stephanie Leary (stephanieleary) wrote :

I believe all we need here is the multisort option on the grid. Branch here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/lp2021755-staff-portal-grid-sort-priority

Someone please correct me if local sorting is not the appropriate method here!

To test:

1. Visit /staff/admin/local/config/ui_staff_portal_page_entry
2. In the grid settings dropdown, choose "Manage Columns"
3. Verify that you can see the sort priority inputs
4. Change the sort priority of a column and verify that it sorts as you expect
5. Save the grid settings, refresh the page, and verify that your sort priority is still set

tags: added: pullrequest
Changed in evergreen:
assignee: Stephanie Leary (stephanieleary) → nobody
Revision history for this message
Susan Morrison (smorrison425) wrote :

I am able to see and input the sort priority inputs, but the grid doesn't sort as expected after a save and refresh.

Revision history for this message
Andrea Neiman (aneiman) wrote :

Testing on terran-main.gapines.org for BSW, and it's working for me - though I'll hold off on a signoff because it's my team's work.

Sort order applied in /staff/admin/local/config/ui_staff_portal_page_entry:

Page column = 1
Entry Type = 2
Entry Label = 3

I saved & refreshed, and I do see it sorted ascendingly first by page column, then by entry type, then by grid label.

Revision history for this message
Terran McCanna (tmccanna) wrote :

My fault - when Susan tested on 3/19 my server was having issues. Now that all the pieces are in place, it looks good! I'll add my signoff:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp2021755-staff-portal-grid-sort-priority-signoff

tags: added: signedoff
Revision history for this message
Terran McCanna (tmccanna) wrote :

Well, after looking at this during Monday Code Review Party, it seems that the only time the sort works is in the order that we tested - when changing to sort by other columns, it didn't actually work.

tags: added: needswork
removed: pullrequest signedoff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.