Angular staff interface: BS5 checkbox styling too understated

Bug #2019735 reported by Galen Charlton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned

Bug Description

With the upgrade of the Angular staff interface to Bootstrap 5 (see bug 2000482), I am finding that the new default 1px border style for checkbox inputs is a bit too understated.

In fact, I literally spent a couple minutes wondering if the checkboxes had somehow disappeared from the Load MARC Order Records form.

Consequently, I think we should do something to make them more visible. Prior to the upgrade to Bootstrap 5, the border width was 2px; not sure whether that was coming from Bootstrap 4 or browser defaults.

Changing the checkbox border width back to 2px was enough for me, although perhaps the border color should be looked at as well.

Evergreen 3.11+

Galen Charlton (gmc)
tags: added: accessibility angular
description: updated
Revision history for this message
Stephanie Leary (stephanieleary) wrote :

Agreed that we should restore the border. The checkboxes are also tiny in some places, so I've set a minimum height and width to 1rem.
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/lp2019735-checkbox-borders

tags: added: pullrequest
Andrea Neiman (aneiman)
Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
milestone: none → 3.11.1
Revision history for this message
Galen Charlton (gmc) wrote :

Works for me! Signoff branch is user/gmcharlt/lp2019735_signoff

tags: added: sig
tags: added: signedoff
removed: sig
Revision history for this message
Galen Charlton (gmc) wrote :

Going through my queue of signoffs that have stood at least a week and are straightforward, so have pushed to main and rel_3_11. Thanks, Stephanie!

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.