Line item checkbox IDs are numeric; need prefix
Bug #2019031 reported by
Stephanie Leary
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Low
|
Unassigned | ||
3.11 |
Fix Released
|
Low
|
Unassigned |
Bug Description
Filing this separately from bug 2009092, because this won't break anything essential, but we do need to fix it: the line item checkbox IDs in the PO list are numeric. For various reasons, HTML ID attributes need to start with a letter. (See https:/
[id]="li.id()" should be something more like [id]="'
... however, I'm not confident I can change this here without fouling up the logic elsewhere, so I'll let someone else tackle this.
Standardizing our DOM ID attributes would help us avoid these errors; see bug 2018410.
Changed in evergreen: | |
assignee: | nobody → Terran McCanna (tmccanna) |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Now that I have worked with this screen a bit more, I'm pretty sure we can fix these IDs without affecting any other logic on the page. Branch: https:/ /git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ sleary/ lp2019031- lineitem- id-prefix
To test, visit any page that includes a list of line items, like a PO (/eg2/en- US/staff/ acq/po/ 1). Inspect the checkbox next to the line item's title. You should see that it has an aria-labelledby attribute that starts with 'lineitem-', and the following <a> tag has a matching ID attribute.