Edit link near call number should only appear if staff has the appropriate UPDATE_VOLUME permission

[Mary Llewellyn]

Version 3.9.2

We would like the Edit link near the call number in the angular catalog item table to only be visible if
staff has the appropriate UPDATE_VOLUME permission.

What we're seeing: all items on the Item Table are showing the "edit" link, regardless of which library owns the item.
What happens: clicking on it opens the Holdings Editor (we're using the unified view).
The Apply All, Save & Exit button is active, but a permission box appears, making it look like permission is possible. However, if you click OK/Continue, the box just reappears instead of showing any message that permission is denied. So, at least the library can't edit the item or call number if it doesn't belong to them, but it's a long way around.

What we'd like to see: the "edit" link should not appear if the call number is attached to an item not owned by the library, in the same way it doesn't display near the barcode.

[Christine Morgan (cmorgan-z)]

Confirmed in 3.9.1

[Dan Guarracino (dguarracino)]

Confirmed in 3.11.1

This is similar to bug #1920815 (only for holdings / call numbers rather than items) and may also have a similar fix(?)

[Terran McCanna (tmccanna)]

The New Devs group worked on this proposed patch together:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp2015112_call_number_edit_link