Evergreen

form labels needed in edit-org-unit-setting-dialog

Bug #2009853 reported by Stephanie Leary
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
Evergreen 3.12-beta
3.11
Fix Released
Medium
Unassigned
Evergreen 3.11.2

Bug Description

In staff/admin/local/org-unit-settings/edit-org-unit-setting-dialog.component.html, all the form inputs need unique IDs and <label for="$ID"> tags.

Revision history for this message
Stephanie Leary (stephanieleary) wrote :

Branch here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/lp2009853-org-unit-settings-edit-labels

To test, visit /eg2/en-US/staff/admin/local/asset/org_unit_settings and click any setting's Edit button in the grid. With the editor modal open, run WAVE or Axe DevTools and verify that there are no errors regarding form labels.

tags: added: pullrequest ux-forms
Changed in evergreen:
milestone: none → 3.12-beta
Jane Sandberg (sandbergja)
Changed in evergreen:
status: New → Confirmed
Andrea Neiman (aneiman)
Changed in evergreen:
importance: Undecided → Medium
Revision history for this message
Ruth Frasur Davis (redavis) wrote (last edit ):

When testing using Axe DevTools, this error related to form labels came up. This does appear to be for the page, however, and not just the modal. There were no errors related to form labels in the edit modal.

https://axe.deque.com/issues/094bacea-6ad7-4f28-88e6-69dea145e781

I consent to sign off on this fix with my username, rfrasur, and email address, <email address hidden>.

tags: added: signedoff
Terran McCanna (tmccanna)
Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
Revision history for this message
Terran McCanna (tmccanna) wrote :

Thanks Stephanie and Ruth!

Fix committed and pushed back to 3.11. (Did not apply cleanly to 3.10.)

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Terran McCanna (tmccanna) → nobody
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.