SIP counts non-open transactions as fine items

[Jeff Davis]

Evergreen's SIP interface uses open-ils.actor.user.transactions.history.have_balance to retrieve transactions with non-zero fines; this includes transactions that are no longer open and no longer show up in the staff client, which is probably not what you want. (Among other issues, the "fee amount" included in the SIP patron information response only includes open transactions, so the current behavior can result in Evergreen reporting multiple "fine items" but an outstanding fee amount of $0.) SIP ought to use open-ils.actor.user.transactions.have_balance instead.

[Jeff Davis (jdavis-sitka)]

Working branch user/jeffdavis/lp2009641-sip-open-fine-items has a fix:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp2009641-sip-open-fine-items

[Galen Charlton (gmc)]

I think .../SIP/Transaction/FeePayment.pm needs to be looked at as well, as otherwise a fee payment via SIP2 might attempt to pay outstanding balances on fees whose underlying transaction is closed.