Semantic markup & better contrast for search result highlights

Bug #2009073 reported by Stephanie Leary
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned

Bug Description

As noted in bug 1970946, as of 3.7.2 or so the search result highlight colors make links difficult to read due to the lack of contrast. We should also use <mark> instead of <b> for better screen reader announcements of search matches.

Branch:
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/lp1970946-search-result-highlight-contrast

tags: added: signedoff
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks, Stephanie! These are good improvements. Signoff at user/sandbergja/lp2009073-signoff

A note that I tried this with VoiceOver, NVDA, and Narrator, and only one of them (NVDA) announced the highlighting. It's still an improvement for NVDA for sure, and semantic markup is always a plus, but we might want to consider adding some visually hidden text announcing the beginning and end of the highlight as a future enhancement for other screen readers.

I tried this with Windows high contrast mode as well; it was readable using each of the Windows contrast themes.

Changed in evergreen:
importance: Undecided → Medium
milestone: none → 3.10.2
Galen Charlton (gmc)
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed down to rel_3_10, along with a release notes entry in rel_3_10 for 3.10.2. Thanks, Stephanie and Jane!

Noting (and per discussion with Stephanie) that this patch has the side effect of fixing the color contrast issues for search highlights in the Bootstrap OPAC using the default styles. Consequently, the main point of the release notes entry is to call this out for any site that has local styles for the oils_SH CSS class.

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Galen Charlton (gmc) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.