Modal title and close button not visible on some modals

[Jane Sandberg]

Steps to recreate on any branches that include the patch for bug 1999954:
1) Open the holdings editor in the angular staff catalog
2) right click on an item
3) select Add/Manage Item notes
4) Note that you can't see the text at the top of the modal, nor can you see the close button

This was an unintended side effect of bug 1999954 -- it works great if the modal header has the classes .modal-header AND .bg-info, but if .bg-info is missing, it leads to white text on a white background -- not very visible!

Patch coming up soon.

[Jane Sandberg (sandbergja)]

Patch at: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp2008918-modal-header-color

Branch name: user/sandbergja/lp2008918-modal-header-color

Testing notes from the commit:
    1) Open the holdings editor in the angular staff catalog
    2) right click on an item
    3) select Add/Manage Item notes
    4) Note that you can't see the text at the top of the modal, nor can you see the close button
    5) Apply this patch and repeat steps 1-3
    6) Note that the modal header is a darker color, so the text and close button are again visible.

[Stephanie Leary (stephanieleary)]

Thanks for catching that, Jane! Signoff: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/lp2008918-modal-header-color-signoff

[Galen Charlton (gmc)]

The color #062C65 is not the same as the color used in the header of the modals that have "modal-header bg-info", so this patch introduces an inconsistency.

Now, white on #17a2b8 has a contrast ratio of only 3.04 to 1, so that doesn't seem to be the way to go unless we increase the size or weight of the modal title text.

So, should we be planning on across-the-board replacement of

class="modal-header bg-info"

with

class="modal-header" ?

[Jane Sandberg (sandbergja)]

That seems like a reasonable approach to me, Galen. One less thing to have to remember when implementing a modal! I added a second commit removing bg-info to this branch: user/sandbergja/lp2008918-modal-header-color-2

FWIW, I have exactly no ties to #062C65 -- it was just a random color with good contrast that I saw in a recent commit.

[Galen Charlton (gmc)]

I think we're almost there, but I've pushed a signoff branch to user/gmcharlt/lp2008919_round3 that includes a follow-up to standardize the modal header background color to "info cyan".

Requesting one last review from Jane and/or Stephanie.

[Stephanie Leary (stephanieleary)]

Yes, let's use the variables whenever possible. Signing off! https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/lp2008919_round3-signoff

[Galen Charlton (gmc)]

Pushed down to rel_3_9. Thanks, Stephanie and Jane!

Noting that the rel_3_9 version includes an extra commit to explicitly set the background color of the modal title, as the patches for bug 1991562 are not in rel_3_9.