setting Default Search Pane fails in Angular 3.11 catalogue

[Carol Witt]

When testing 3.10 on our development server, I set my Default Search Pane to Numeric Search in the Angular catalogue's Search Preferences. The message "Setting Update Succeeded" appeared; however, my default advanced search remained as Keyword Search in the Angular catalogue. All of the other search preferences changed immediately.

Changing to the other options in the Default Search Pane's dropdown menu (MARC Search, Browse, and Shelf Browse) also failed in Angular. The Default Search Pane remained Keyword search even after returning to the home page and clicking Advanced Search, or after signing out and back in.

Opening the Traditional catalogue showed that my Default Search Pane changes had succeeded as per the message, which is what I expected to happen in Angular.

I tested this using an incognito window in Chrome, and also tried in a regular Chrome window with the same results.

We are currently using 3.7.3 on our live server, where the Default Search Pane setting changes immediately in the Angular catalogue.

[Elaine Hardy (ehardy)]

I cannot recreate this in 3.10. When I set my search preferences from the search screen, it sticks, even if I sign out and close the browser.

[Jason Stephenson (jstephenson)]

The server where Carol sees this runs 3.10, plus some template customization, and patches from bug 1959010 as well as bug 1948693. It may be more appropriate to test this on master with the former patch applied.

I should add that a server running similar template customization on Evergreen 3.7.3 with the old WIP code for bug 1959010 does not show this behavior. I'm not ruling out the customization and this being a local problem, but it may have something to do with the ngbNav changes and the new catalog summary.

[Elaine Hardy (ehardy)]

PINES does have 1959010 applied and probably not the other.

[Shannon Dineen (sdineen)]

I can reproduce this on https://bugsquash.mobiusconsortium.org/ today for bug squashiing
as admin @ SPLS-BPL-co-op on current Chrome configured for this test server. I am on WIN 10

Search preferences appear to save but do not, default view is keyword search as noted above.
All other settings on Search Preferences work

[Andrea Neiman (aneiman)]

I am not able to reproduce this on stock 3.10 (i.e. without the two patches Jason notes in comment #2) but I do see it in an Equinox 3.11 test system.

[Jennifer Pringle (jpringle-u)]

I can reproduce this in 3.11 on our test server and EOLI's community server

[Galen Charlton (gmc)]

This was introduced by the patch for bug 1948693, which accounts for why this was a problem in that particular 3.10 test system but only crops up in stock systems as of 3.11.

[Galen Charlton (gmc)]

A patch is available in the branch working/user/gmcharlt/lp2007603_cat_search_tab_pref / https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp2007603_cat_search_tab_pref

[Jennifer Pringle (jpringle-u)]

Tested with the patch on our test server and the selected default search pane is now used as expected in the angular staff catalogue.

I have tested this code and consent to signing off on it with my name, Jennifer Pringle and my email address, <email address hidden>.

[Jeff Davis (jdavis-sitka)]

Thanks, Galen et al.! Pushed to rel_3_11 and main.