Deleting Last Copy Fails to Create Hold Cancel Notice

[Bill Erickson]

Evergreen 3.10 + Previous Versions

To recreate:

* UPDATE action_trigger.event_definition SET active = TRUE where id = 38;
* Create a bib with one copy
* Check in the new copy so it's targetable
* Place hold on the bib and confirm it targeted
* delete the last/only copy on the bib.
* confirm the new hold has been canceled with cancel cause "1".

1. Note the lack of additional rows in action_trigger.event where event_def = 38.
2. These errors appear in open-ils.trigger_stderr.log

Caught error from 'run' method: Invalid date format: now at /usr/share/perl5/Error.pm line 465.

--

The error comes from attempting to parse the string "now" (as the hold cancel time) as a date string.

Patch en route.

[Bill Erickson (berick)]

Fix:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp2007591-last-copy-hold-cancel-notice

[Katie Greenleaf Martin (kgmspark)]

I tested this on https://bugsquash.mobiusconsortium.org/eg/staff and get the error message "Reason(s) include: This title has hold requests on it that will be canceled if they are not transferred." when I try to delete the last item on a bib that has holds.
(I also confirmed that this is still an issue in our 3.9 installation)

[Terran McCanna (tmccanna)]

(Noting that the testing failure may be due to an issue on the current test server.)

[Mike Rylander (mrylander)]

Works for me! Committed to master, rel_3_10, and rel_3_9. Thanks, Bill!

Katie, I suspect that, or settings blocking delete of the last copy (which you couldn't have changed because of the test server issue) were stopping you.