Angular login redirect issue

[Terran McCanna]

Evergreen 3.10

We've found that a number of staff create bookmarks or set their browser home page to the Angular splash page (/eg2/en-US/staff/splash). However, going to this page and then logging in ends up with an odd double-redirect / double-URL encoding issue that results in a white screen.

To recreate this problem on a 3.10 server (at the time of this report, terran-master.gapines.org is installed with 3.10ish current master and no customizations):

1. Go to https://terran-master.gapines.org/eg/staff and log in (Concerto data) and set up a workstation.
2. Bookmark (or copy) the splash page URL (https://terran-master.gapines.org/eg2/en-US/staff/splash) and then log back out.
3. Click on the bookmark (or go to the saved splash page URL) and note that it creates this wonky URL that duplicates the en-US part of the path and double-encodes the URL slash (/) as %252F:

https://terran-master.gapines.org/eg2/en-US/staff/login?routeTo=%2Feg2%2Fen-US%2Fstaff%2Flogin%3FrouteTo%3D%252Feg2%252Fen-US%252Fstaff%252Fsplash

4. Log in and note that it redirects to https://terran-master.gapines.org/eg2/en-US/ which gives you a white screen. Refreshing the page gives the "Welcome to Webby" screen.

Dan B. identified that it appears to be calling two redirects - one in staff/resolver.service.ts and one in staff/staff.component.ts

[Joan Kranich (jkranich)]

Release 3.10
Chrome

I am experiencing the white screen and the Welcome to Webby screen anytime Evergreen times out and I am logged out. I first get the white screen and then clicking on another tab will either come up with a white screen or go to the Welcome to Webby screen. This has occurred every time I have been logged out due to a timeout and I attempt to log in again.

[Elaine Hardy (ehardy)]

I also get the white screen and then the Webby screen when I time out and then log back in. Redisplaying the browser page restores the expected splash page.

[Bill Erickson (berick)]

A fix:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp2006513-angular-login-redirect-fix

[Jane Sandberg (sandbergja)]

Resolves the issue perfectly. Thanks, Bill! Pushed to rel_3_10 and above.