Cash Reports allows start date after end date

[Susan Morrison]

Evergreen 3.8 and 3.10

In the Cash Reports interface, the date pickers do not check to make sure the end date is after the start date for the time period selected. If a start date is after the end date, it produces no results, but it would be helpful to have an error message to alert the issue.

[Elizabeth Davis (elidavis)]

Confirming that I see this in 3.9.2.

[Jane Sandberg (sandbergja)]

Thanks for catching this, Susan, and for confirming it, Elizabeth. Here is a branch: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp2002343-validate-cash-reports-dates

[Galen Charlton (gmc)]

Signoff pushed to user/gmcharlt/lp2002343_signoff. Note that the signoff includes a follow-up patch to tidy up after the patch for bug 2000482 broken the intended columnar (on large screens) layout of the inputs on this page.

[Galen Charlton (gmc)]

Also noting that I've changed this from a wishlist to a bug; while adding the additional validation is an enhancements, the prior lack of validation is arguably a bug.

[Bill Erickson (berick)]

Thanks All. Does the thing. Layout improved. Tests/lints clean. Merged to main and 3.11, including a tiny follow up patch to make the --configuration=production build happy (rename template variable).