reporter draw folder fails when sharing rules broken

[Llewellyn Marshall]

Evergreen 3.9.1

In our reporter module we have staff members who have created shared template folders with hierarchies that are broken. For example, subfolders that are shared while their parent folders are not. This will reliably crash the javascript function that draws the folders, causing staff members to be unable to access their shared folders. We've developed a small patch in the javascript for that page that will catch the error and report it in the console rather than allowing the whole function to crash. Pushing this patch to production has fixed the issue our staff members were having.

Our patch is on this working branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/lew/reporter-draw-folders-glitch

[Blake GH (bmagic)]

I've tested and it works as described. My sign-off:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/blake/lp1999944-reporter-draw-folders-glitch

[Galen Charlton (gmc)]

Pushed on down to rel_3_9. Thanks, Llewellyn and Blake!

This may be more for the eventual Angularization of the reporter, but it occurs to me that having shared subfolders whose parent is not shared is not necessarily a conceptual error on the part of the user. I.e., perhaps they should just be attached to the nearest available ancestor if the user fetching the folders does not have access to the parent folder.