eg-pbx-mediator.pl - Asterisk - function name changed

[Josh Stompro]

Hello, this has been an issue since we first started using the Asterisk integration in 2016.

RPC::XML::Server at some point used a function called add_proc, which was renamed to add_procedure() sometime before 2016.

So the eg-pbx-mediator.pl needs to have all instances of ->add_proc changed to ->add_procedure.

Working branch up next.

Using librpc-xml-perl package 0.76.3 in production. 0.82 is the latest release from Jan 6 2021. I tried spotting when exactly the function name changed, 0.72 used add_proc, 0.75 seemed to be the version to change to add_procedure. The pbx-daemon scripts were released in 2010.

Links for more info about the EG PBX software.
https://git.evergreen-ils.org/?p=Evergreen.git;a=tree;f=Open-ILS/src/asterisk/pbx-daemon;hb=HEAD
https://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=docs/TechRef/Telephony/telephony-setup-guide.adoc;hb=HEAD

[Josh Stompro (u-launchpad-stompro-org)]

Branch at user/stompro/lp1999065-eg-pbx-mediator-procedure

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1999065-eg-pbx-mediator-procedure

Error message when launching without fix is
Can't locate object method "add_proc" via package "RPC::XML::Server::new:

I'm not sure how much setup is needed for a minimal test, to be able to launch the script to hit the error, or confirm that it works. Hopefully another site is using this also, and can confirm things.

If no one else is still using the pbx-daemon scripts then we can just track these fixes locally.

Josh

[Galen Charlton (gmc)]

Change makes sense, and certainly none of the supported Linux distributions are shipping a version of RPC::XML::Server old enough to use the deprecated method name. I've gone ahead and pushed this to master so that this doesn't get lost track of. Thanks, Josh!