Archiving a course removes materials from other courses too

[Jane Sandberg]

A huge thank you to Michele Morgan for identifying this issue, and for providing the following steps to reproduce:

* Login to BR1 workstation
* Set ou setting circ.course_materials_opt_in to TRUE
* Go to Admin - Local Admin - Course Reserves List
* Create two courses, Course 1 and Course 2
* Associate materials to both courses
* Archive Course 1
* Go to Course materials on Course 2 and not that there are no items associated.

I believe this regression came in with commit 5e812fb64f612efd5cecb18a97a4c857dc4da3d7, where a pcrud.search for all matching course materials to delete was changed to a retrieveAll, which does not observe those crieteria. Branch coming up soon.

[Jane Sandberg (sandbergja)]

Here is the branch: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1993922_course_archiving_data_loss_issue

[Beth Willis (willis-a)]

I tested this patch on Terran’s community test server following the steps that Michele outlined in the initial bug report:

* Login to BR1 workstation
* Set ou setting circ.course_materials_opt_in to TRUE
* Go to Admin - Local Admin - Course Reserves List
* Create two courses
* Associate materials with both courses
* Archive Course 1

NOTE: Archiving of Course 1 did not cause items to be disassociated from Course 2. So, this patch is working as expected.

I have tested this code and consent to signing off on it with my name, Beth Willis and my email address, <email address hidden>.

One minor note: When the course is archived the following toast displays: "Archival of course succeeded." If possible, could this text be edited to "Archiving of course succeeded" or "Course archived
successfully?"

[Michele Morgan (mmorgan)]

This fixes the issue nicely! Pushed to master, rel_3_9 and rel_3_8.

Also added an additional commit that corrects the messaging, changing the adjective "Archival" to the verb "Archiving" as Beth suggested.

Big thank-yous to Jane and Beth!