rxjs empty() function is deprecated

[Jane Sandberg]

Here is the documentation: https://rxjs.dev/api/index/function/empty

In most cases, the fix should be very simple:
1) Import EMPTY instead of empty
2) Change empty() to EMPTY in the typescript code

I don't think this will bite us anytime soon (it's scheduled for removal in rxjs 8, and Angular 14 is still on rxjs 6). But it's some low-hanging future-proofing fruit.

[Shula Link (slink-g)]

Went ahead and took care of this.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=7b8f5355407b87d391387bbd85a266fe2b1341b1

[Shula Link (slink-g)]

Located a few other references to empty()

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=edecdbc537c21c34ba743812b222076677355e5d

[Jason Stephenson (jstephenson)]

Shula, this is great!

I have a couple of suggestions regarding the commit messages that will make things easier for reviewrs and committers:

It's customary for us to put the Launchpad Bug number at the beginning of the first line of the commit message, likes so:

LP1991344: ....

You will see several variations on how that's done, but it's a useful cue that the commit comes from a LP bug and makes it easy to look up the bug in case anyone has any questions about it.

It's also useful to provide a brief sentence or two about why the change is being made in the lines below the first line of the commit message. This way the final committer or tester may not have to refer to the Lp bug to know what's going on.

If you can link to the branch rather than individual commits when adding links to Launchpad comments, that helps with possibly avoiding missed code, etc.

If you'd like to make those changes and want any help, feel free to bug Dyrcona in #evergreen on irc.libera.chat.

Thanks, again, for sharing these changes!

[Shula Link (slink-g)]

Thanks, Jason! I squashed the two commits together; the branch can be found here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/slink/1991344_rxjs_empty_function_deprecated

[Jane Sandberg (sandbergja)]

Thanks for the patch, Shula! It looks like there are four commits now on your branch -- could you please try the squash again?

Also, it should be safe to simply remove the imports in files where empty isn't actually used. Apologies for not mentioning that in the ticket!

[Shula Link (slink-g)]

All commits squashed, empty() removed from imports where it's not being used, and the branch remains the same. This has been a fun learning experience :)

[Jane Sandberg (sandbergja)]

Thanks, Shula! Merged.