Wishlist: Record Note Tab

[Elizabeth Thomsen]

The Record Note is potentially a useful feature, but there's nothing on the Record Note tab that shows that there is a note. Since it's unlikely that most records will have notes, staff are unlikely to open that tab and see the note. This tab should have an indication if there are notes, similar to the indications used to show that there are records in a basket, or that a patron has items checked out, etc.

A simple Record Note (1) similar to Items Out (1) would be all that's needed.

[Elizabeth Thomsen (et-8)]

Confirming that this is still a valid wishlist item through Release 3.11.

[Jane Sandberg (sandbergja)]

Here is a branch adding this count to the record tab, created on behalf of PaILS: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1991103-record-notes-tab

I'll add the pullrequest tag once PaILS has finished testing it.

[Elizabeth Davis (elidavis)]

I have tested this code and consent to signing off on it with my name, elizabeth davis and my email address, <email address hidden>

[Tiffany Little (tslittle)]

I looked at this on terran-main today. I tested as both admin and br1dbeck, and added a record note to bib #150.

For me, the Item Table was the default view for records. When pulling up a record either via Cataloging>Retrieve Bib Record by ID or via a search, when the record loads on the Item Table there is no indication on the Record Notes tab that a note exists. However, once you click the Record Notes tab, it updates the tab header that there is a note and that notification persists on the tab header if you move between tabs on the record.

However, if you leave the record and search for it again, the notification is gone from the Record Notes tab until you open the Record Notes tab again.

[Jane Sandberg (sandbergja)]

Hi Tiffany, thanks for your testing! Could you please give it another try? We noticed in the collaborative code review today that some of the Perl code hadn't gotten installed yet. We installed it in that meeting so it should be ready for another look.

[Galen Charlton (gmc)]

Noting bug 2055187. I don't think this affects whether the patch should be merged or not, since as it happens, unless you are manually updating biblio.record_note rows, its deleted column will never be set to true, as the rows will just get deleted outright.

However, once the question posed by that bug is resolved, there will be follow-up changes needed. If biblio.record_note.deleted is removed, there are a couple references to that field that should be removed in the current patch. If that column is retained and made part of a mechanism to logically delete bren rows, a couple methods will need to be updated, including one used by this patch.

But to emphasize, I don't think that bug 2055187 should hold up this patch (unless, I suppose, somebody were super keen to implement full logical deletion of record notes ASAP).

[Galen Charlton (gmc)]

However, I note that one of the test cases supplied in the patch fails at present.

[Jane Sandberg (sandbergja)]

Thanks, Galen. What failure are you getting, so I can take a look?

[Tiffany Little (tslittle)]

Thanks Jane! I retested this code this morning, and it works for me now. The record note tab is populated upon accessing a record (when a record note is present), adding a new record note updates the count, deleting a note updates the count, and upon leaving and re-accessing the record the count immediately appears.

I'm happy to add my signoff in addition to Elizabeth's after this morning's testing.

I have tested this code and consent to signing off on it with my name, Tiffany Little, and my email address, <email address hidden>.

[Galen Charlton (gmc)]

Firefox 115.0 (Linux x86_64) RecordComponent displays the number of record notes in the tab FAILED
        Expected 'Set Default View
        Staff View
        Item Table
        MARC Edit
        MARC View
        edit_noteRecord Notes(8)
        View Holds
        Monograph Parts
        Holdings View
        Conjoined Items
        Shelf Browse' to contain 'Record Notes (8)'.
        <Jasmine>
        43764/</<@main.js:18351:45
        <email address hidden>:436:158
        <email address hidden>:25961:33
        <email address hidden>:436:46
        <email address hidden>:219:35
        <email address hidden>:26240:28
        wrapTestInZone/<@vendor.js:26255:14
        <Jasmine>
        runInTestZone/</testZoneSpec</<@vendor.js:26998:11
        <email address hidden>:436:158
        <email address hidden>:25961:33
        <email address hidden>:436:46
        <email address hidden>:219:35
        runInTestZone/</testZoneSpec<@vendor.js:26997:21
        _finishCallbackIfDone/</this._existingFinishTimer<@vendor.js:26816:20
        <email address hidden>:2414:27
        <email address hidden>:463:171
        <email address hidden>:265:37
        <email address hidden>:540:26
Firefox 115.0 (Linux x86_64) WARN: Object{pid: 10241, servertime: 'Sun Oct 15 06:05:50 2023', stacktrace: '/usr/local/share/perl/5.30.0/OpenILS/Application/Booking.pm:213 /usr/local/share/perl/5.30.0/OpenSRF/Application.pm:628 /usr/share/perl5/Error.pm:465
', ilsevent: '', textcode: 'RESOURCE_IN_USE', desc: 'Resource is in use at this time'}
Firefox 115.0 (Linux x86_64): Executed 57 of 116 (1 FAILED) (0 secs / 1.679 secs)
Chrome Headless 119.0.6045.159 (Linux x86_64): Executed 1 of 116 SUCCESS (0 secs / 0.916 secs)
Chrome Headless 119.0.6045.159 (Linux x86_64) RecordComponent displays the number of record notes in the tab FAILED
        Expected 'Set Default View
        Staff View
        Item Table
        MARC Edit
        MARC View
        edit_noteRecord Notes(8)
        View Holds
        Monograph Parts
        Holdings View
        Conjoined Items
        Shelf Browse' to contain 'Record Notes (8)'.
            at <Jasmine>
            at UserContext.apply (src/app/staff/catalog/record/record.component.spec.ts:54:49)
            at _ZoneDelegate.invoke (node_modules/zone.js/fesm2015/zone.js:375:26)
            at ProxyZoneSpec.onInvoke (node_modules/zone.js/fesm2015/zone-testing.js:287:39)
            at _ZoneDelegate.invoke (node_modules/zone.js/fesm2015/zone.js:374:52)
Firefox 115.0 (Linux x86_64): Executed 111 of 116 (1 FAILED) (0 secs / 2.556 secs)
Chrome Headless 119.0.6045.159 (Linux x86_64): Executed 76 of 116 (1 FAILED) (0 secs / 1.998 secs)
Chrome Headless 119.0.6045.159 (Linux x86_64) RecordComponent displays the number of record notes in the tab FAILED
        Expected 'Set Default View
        Staff View
        Item Table
        MARC Edit
        MARC View
        edit_noteRecord Notes(8)
        View Holds
        Monograph Parts
        Holdings View
        Conjoined Items
        Shelf Browse' to contain 'Record Notes (8)'.
           ...

[Stephanie Leary (stephanieleary)]

Some notes on the styles:

- I don't think the tab should include an icon. Most don't, and adding icons makes the words harder to scan.

- The number is not a warning and shouldn't be yellow. I don't think it really needs a background color at all; if we want it to stand out a bit, bold text would be fine. If we must use color, it should probably be the blue badge style, to blend more seamlessly with the link text.

(I am taking notes for things we need to include in our nascent style guide!)

[Jane Sandberg (sandbergja)]

Thanks, Tiffany, Galen, and Stephanie. I've pushed a second commit to get the test passing and remove the icon here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1991103-record-notes-tab

Stephanie, thanks for the feedback on the styles. One question about the warning color: I went that direction because that's how PaILS is planning to use it -- their record notes will be warnings to catalogers that say "Don't attach holdings to this record!" Of course, that may not be how everyone is planning to use record notes, but I want to make sure it meets that use case. What do you think?

[Jason Boyer (jboyer)]

I'm going to push back on the "record notes mean don't add holdings" use case. Evergreen has a "prevent adding holdings to this record" feature already, in Bib Sources (can_have_copies = false). Last I knew there wasn't a great interface for adding / editing sources, but that's how you completely stop someone from adding copies to a record. (Of course, in exceptional circumstances it could be changed, an item added, and then changed back.)

Notes in general don't imply a warning, just something that shouldn't necessarily be in the marc itself. Adding a "record alerts" feature might warrant more colorful notifications but I don't know that we need to go that far.

[Galen Charlton (gmc)]

To Jason's point, I don't believe that the can_have_copies flag is checked by any AngularJS or Angular interfaces - see bug 2055318.

[Elizabeth Thomsen (et-8)]

I agree that if the issue is just to prevent holdings being added to a record, a setting like can_have_copies = false is the way to go -- if something is a rule, it's always better to tell the system rather than tell the users.

Text notes like this are useful in situations where you want to give more specific information to the user. For example, we might want to have notes like "Don't add any new holdings to this serial record, new editions of Fodor's France should be added to monograph records. See Record #1234557 as an example."

It could be useful to have different categories of record notes, designating some as alerts and some as plain old notes, and associate different colors to each, but that could be a future enhancement when people have more experience using record notes.

[Elizabeth Thomsen (et-8)]

Another possible enhancement would be to specify depth for notes, so in a shared catalog, a system could have a Record Note that is specific to how they handle current and future attached items -- but I think that should be a new wishlist item that would make more sense to add once the record note tab has the indicator that's going to make it so much more likely that libraries will use this!

[Terran McCanna (tmccanna)]

Tested during Monday Code Review session today and everything looked good except for the highlighting color, which should be changed to: class="badge text-bg-primary fw-bold"

Also noting that staff need to have the permission at the global level in order to add notes as all notes are global at this point. (Elizabeth's comment #17 would be a good new wish list ticket.)

[Jane Sandberg (sandbergja)]

Thanks, everyone. I...
* ... rebased,
* ... added Elizabeth's and Tiffany's signoffs to the first commit,
* ... amended the second commit to include the correct styles, and
* ... force-pushed to the same branch: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1991103-record-notes-tab

[Galen Charlton (gmc)]

I've pushed this, including a follow-up to the documentation to add a note that the permissions must be assigned at the global level.

Thanks, everybody!