Angular secondary interface cleanup (partial: crad and authority)

[Mike Rylander]

Evergreen version: 3.3+

Linked below is a branch that addresses two Angular regressions involving secondary admin interfaces. The first commit provides a link from Record Attributes to Coded Value Maps, so that CVMs can be added, removed and adjusted in the context of a specific Record Attribute. The second provides access to the bib fields that are controlled by specific authority fields, and browse axes mappings for authority fields. The latter was originally reported in bug 1838102.

Branch coordinates:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/angular-ccvm-and-authority-links

[Andrea Neiman (aneiman)]

This work is sponsored by King County Public Library.

[Jane Sandberg (sandbergja)]

Thanks for this branch, Mike! A few issues I noted:

1. If you do the following using the concerto data set:
* Go to Server admin > Authority Control Sets
* Select Controlling Authority Fields
* In the Control Set column, select LoC to go back to the previous screen
* The screen never loads, you get a router error in the console:

ERROR Error: Uncaught (in promise): Error: Cannot match any routes. URL Segment: 'undefined/authority/control_set'
Error: Cannot match any routes. URL Segment: 'undefined/authority/control_set'

2. In Server admin > Authority Control Sets, the "Controlling Authority Fields" and "Thesauri" links both seem to load the linked page from scratch, rather than doing a slick single-page application transition. I'm not sure why this is; at a glance, I didn't see any differences from the routerLink in the CRAD screen, which is working as expected.

3. "No cellTextGenerator provided" warnings in the console for the CRAD and authority control sets grids.

[Mike Rylander (mrylander)]

Belated thanks, Jane!

I've rebased this against current master and fixed the first issue you found -- we need to tell the eg-admin-page component what it's relative base is for linked field generated content.

The other two seem to be general (and harmless) eg-grid bugs. I think the grid should not complain about the lack of a cellTextGenerator if there is a template assigned to the column via templateFields. I'm judging those out of scope for this UI specifically.

Updated branch available at: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp-1989151-ang-ccvm-and-authority-fix-and-rebase

IMO, all three commits can be squashed together at commit time.

[Jennifer Pringle (jpringle-u)]

I can confirm that the link from Record Attributes to Coded Value Maps is now present and works, however, the ability to Save Grid Setting in the Record Attributes interface is now broken (saving works as expected in 3.9.1). I think this needs to be fixed before the bug can be signed off on.

The links in Authority Thesauri and Authority Control Sets also work; however, they already work in 3.9.1 and I'm not seeing any obvious difference on the test server from 3.9.1. Could they have been fixed by a related secondary admin issue or am I missing something here?

[Mike Rylander (mrylander)]

I've rebased this again, and added an explicit persist key to the CRAD admin UI, which now can't quite figure out where it lives.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp-1989151-secondary-interfaces-rebase-and-grid-settings-fix

[Mike Rylander (mrylander)]

I've rebased this again for hopeful 3.12 inclusion. New branch at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp-1989151-secondary-interfaces-rebase-and-grid-settings-fix-rebase

[Jane Sandberg (sandbergja)]

Thanks for bringing these screens back, Mike! Andrea, Steven, Stephanie, and I took a look at it today, and confirmed that it's working as expected, with new Manage links available in:

* /eg2/en-US/staff/admin/server/authority/control_set_authority_field?gridFilters={"control_set":1}
* /eg2/en-US/staff/admin/server/config/record_attr_definition

Squashed and pushed to main for inclusion in 3.12