patron credit payments not working

[Jason Etheridge]

There's an uncaught exception in master if you try to pay a bill with the Patron Credit type and the patron has no credit forward balance.

Payment was rejected: TypeError: Cannot read properties of undefined (reading 'last_xact_id')

[Jason Etheridge (phasefx)]

Actually, I made an assumption here that was untrue, wanting to get this bug out of my head to move on to other things. :D The error seems to happen even if you have patron credit. So a regression, maybe. Can anyone reproduce?

[Garry Collum (gcollum)]

I wasn't able to replicate this in current master. (Ubuntu 18.04). At least not by adding a bill to a patron account using the 'Add Bill' button, over paying with the Convert Change to Patron Credit option selected, and then adding another bill to pay by patron credit.

[Jason Boyer (jboyer)]

I suspect this may be distribution specific and related to the county codes commit from bug 1979357 (affects Buster and newer, which I think lines up with the 20 or 22 Ubuntu release). I haven't had time to verify that, but will try to make some now that I'm seeing this.

[Jason Boyer (jboyer)]

Never mind the junk comment above, that would only affect actual CC payments anyway.
In any case, I'm only able to trigger it when patron credit is 0 and I try to apply a payment.