Locale lookup incorrectly assumes user is event target

[Jeff Davis]

EG 3.9

Bug 1091588 introduced the ability to send notification emails in the user's preferred language. To determine the preferred language, the new code takes the action trigger event target and looks up the locale for that ID in actor.usr. This is a problem because the target is not necessarily an actor.usr ID -- for example, for checkout receipts, the target is an action.circulation ID. For most such events, the event will fail with an "error" state and a message like this in the logs:

Can't use an undefined value as a HASH reference at /usr/local/share/perl/5.30.0/OpenILS/Application/Trigger/Event.pm line 518.

It's also possible that the target will match an existing user ID, in which case the event won't fail but you're using the wrong user's locale.

[Jeff Davis (jdavis-sitka)]

I don't have a fix for this, but for anyone who needs events to work on 3.9, working branch user/jeffdavis/lp1986479-workaround should do that by disabling the code that looks up the preferred language. This is definitely not a solution, just a temporary mitigation.

[Galen Charlton (gmc)]

A patch is available at user/gmcharlt/lp1986479_fix_a_t_usr_locale_lookup / https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1986479_fix_a_t_usr_locale_lookup

[Galen Charlton (gmc)]

Also, I've pushed a follow-up to do a bit of refactoring and to remove checking for hard-coded reactors.

[Galen Charlton (gmc)]

Acknowledging here the contributions that Mike Rylander made to the refactoring portion.

[Mike Rylander (mrylander)]

I've signed off Galen's branch, with the result at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp1986479_fix_a_t_usr_locale_lookup-signoff

[Galen Charlton (gmc)]

This has now successfully been exercised in production, so given its priority, I've merged this for inclusion in 3.9.1.