Ebook API in Bootstrap OPAC needs some work

Bug #1982217 reported by Jeff Davis
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
New
High
Unassigned

Bug Description

EG 3.9+ (earlier versions too, probably)

In the Bootstrap OPAC, there are a few bugs with ebook API integration (i.e. Overdrive):

- The ebook availability grid is missing from the search results screen.
- On search results, buttons for both Check Out E-Item and Place Hold on E-Item show for all results. This allows you to place a hold on an available e-item.
- On record summary, the Check Out E-Item and Place Hold for E-Item buttons don't match the rest of the actions.
- On E-items Ready for Checkout, there is no header for the "Status" column.
- In My Account, the nav menu checkout and hold counts do not include e-items.

Changed in evergreen:
assignee: nobody → Jeff Davis (jdavis-sitka)
tags: added: bootstrap bootstrap-blocker overdrive
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Working branch user/jeffdavis/lp1982217-ebook-api-bootstrap has a series of commits that should resolve these issues:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1982217-ebook-api-bootstrap

tags: added: pullrequest
Changed in evergreen:
assignee: Jeff Davis (jdavis-sitka) → nobody
Revision history for this message
Blake GH (bmagic) wrote :

Merge conflict on master today. base.tt2. I attempted to resolve it for Feedback Fest

tags: added: needsrebase
Changed in evergreen:
assignee: nobody → Jeff Davis (jdavis-sitka)
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Rebased to main: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1982217-ebook-api-bootstrap-2 / user/jeffdavis/lp1982217-ebook-api-bootstrap-2

This branch also includes a fix for an issue where the holdings format for EbookAPI::Test titles displayed as "undefined" instead of "ebook".

You can test the fix on a server with Concerto data as follows:

1. In config.tt2, set ebook_api.enabled = 'true' and ebook_api.ebook_test.enabled = 'true'.
2. Do a keyword search for "tolkien". The results include several records with ebook test holdings.

Changed in evergreen:
assignee: Jeff Davis (jdavis-sitka) → nobody
tags: removed: needsrebase
Changed in evergreen:
milestone: none → 3.13-beta
Changed in evergreen:
milestone: 3.13-beta → 3.13-rc
Andrea Neiman (aneiman)
Changed in evergreen:
milestone: 3.13-rc → 3.13.1
Changed in evergreen:
milestone: 3.13.1 → 3.13.2
Changed in evergreen:
milestone: 3.13.2 → 3.13.3
Changed in evergreen:
milestone: 3.13.3 → 3.13.4
Revision history for this message
Andrea Neiman (aneiman) wrote :

Marking high importance to get eyeballs, since it's tagged as a blocker.

Changed in evergreen:
importance: Undecided → High
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks, Jeff and Andrea! I used the testing process in #3, and it looks way better.

Here's a signoff branch: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1982217-ebook-api-bootstrap-2-signoff

It includes a sixth commit, to update the ebook api live tests to match the correct data structure -- basically it's the test version of Jeff's most recent commit.

tags: added: signedoff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.