Bootstrap OPAC buttons use inconsistent styles
Bug #1981774 reported by
Jeff Davis
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Medium
|
Unassigned | ||
3.9 |
Fix Released
|
Medium
|
Unassigned |
Bug Description
The Bootstrap OPAC introduced a number of new CSS classes for buttons: btn-confirm, btn-deny, btn-remove, btn-opac, and btn-action. However, some buttons still use the opac-button and results_header_btns CSS classes, which are holdovers from the TPAC. These older buttons use different color variables than the Bootstrap buttons. As a result, you can end up with inconsistent button styles depending on how you've set up your OPAC colors.
I think we should get rid of the opac-button and results_header_btns classes and use the new Bootstrap button styles everywhere. There are around 15 buttons in the Bootstrap OPAC that would need to be modified.
tags: | added: bootstrap |
Changed in evergreen: | |
importance: | Undecided → Medium |
status: | New → Confirmed |
Changed in evergreen: | |
assignee: | nobody → Jeff Davis (jdavis-sitka) |
Changed in evergreen: | |
milestone: | none → 3.9.1 |
Changed in evergreen: | |
milestone: | 3.9.1 → 3.9.2 |
Changed in evergreen: | |
milestone: | 3.9.2 → 3.10.1 |
Changed in evergreen: | |
milestone: | 3.10.1 → 3.10.2 |
Changed in evergreen: | |
assignee: | Jeff Davis (jdavis-sitka) → Galen Charlton (gmc) |
Changed in evergreen: | |
assignee: | Galen Charlton (gmc) → nobody |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
There are also some standard Bootstrap button classes that we're using in the OPAC without defining any associated CSS rules: btn-secondary, btn-danger, btn-link, btn-success. For these buttons, I assume we're falling back to Bootstrap's defaults, which may or may not be desirable.
And there are a few non-standard button classes that also don't have any CSS rules: btn- (presumably a typo), btn-group, btn-group-vertical. These should probably be cleaned up.