Bootstrap OPAC buttons use inconsistent styles

[Jeff Davis]

The Bootstrap OPAC introduced a number of new CSS classes for buttons: btn-confirm, btn-deny, btn-remove, btn-opac, and btn-action. However, some buttons still use the opac-button and results_header_btns CSS classes, which are holdovers from the TPAC. These older buttons use different color variables than the Bootstrap buttons. As a result, you can end up with inconsistent button styles depending on how you've set up your OPAC colors.

I think we should get rid of the opac-button and results_header_btns classes and use the new Bootstrap button styles everywhere. There are around 15 buttons in the Bootstrap OPAC that would need to be modified.

[Jeff Davis (jdavis-sitka)]

There are also some standard Bootstrap button classes that we're using in the OPAC without defining any associated CSS rules: btn-secondary, btn-danger, btn-link, btn-success. For these buttons, I assume we're falling back to Bootstrap's defaults, which may or may not be desirable.

And there are a few non-standard button classes that also don't have any CSS rules: btn- (presumably a typo), btn-group, btn-group-vertical. These should probably be cleaned up.

[Jeff Davis (jdavis-sitka)]

Working branch user/jeffdavis/rt92002-lp1981774-bootstrap-buttons has a fix:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1981774-bootstrap-buttons

There are two commits. The first commit cleans up all uses of the opac-button class in the Bootstrap OPAC. The second commit fixes a typo involving a button class in the curbside pickup UI.

I didn't do anything about the results_header_btns class because I couldn't get the relevant button to display (perhaps this is dead code?). I also didn't do anything about the classes that lack CSS rules in Evergreen.

[Garry Collum (gcollum)]

A signed-off branch is at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/lp1981774-bootstrap-buttons-signoff

Just to note - It looks like carts.tt2 is not used in the bootstrap opac.

[Galen Charlton (gmc)]

Pushed down to rel_3_9, along with a follow-up to update a straggler that slipped after the initial pull request. Thanks, Jeff and Garry!

[Galen Charlton (gmc)]

I've opened bug 2013681 to suggest removal of the opac-button class.