new library setting to specify owning library for auto-created line items

Bug #1981714 reported by Galen Charlton
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
New
Wishlist
Unassigned

Bug Description

If the provider for an order has a non-zero default copy count set, adding a line item to an order will also create that number of line item copies (AKA line item items / line item details). Those line item copies have their owning library set to the workstation library.

However, since the workstation library is not necessarily the correct one to set by default, a new library setting will be created to specify the owning library to use.

Evergreen master

Galen Charlton (gmc)
Changed in evergreen:
importance: Undecided → Wishlist
tags: added: acq acq-lineitem
Revision history for this message
Galen Charlton (gmc) wrote :

Thinking through this more, I actually think a pair of settings would do it:

1. How to set the owning library: use workstation library (the current behavior), leave blank, or use OU specified by the second setting
2. the explicit OU to use if the first one is set to consult it, keyed on workstation library

Regarding the second OU, I'm not 100% sure whether the workstation library would be the best context OU for the setting lookup. Would the PO ordering agency be better?

Revision history for this message
Galen Charlton (gmc) wrote :

A WIP patch is available here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=ef2202b174d7508b450993d03be31f52ff23ad4a

Also, it turns out there's a relevant bug in the Dojo Library Settings editor that needs to be fixed to use one of the new settings. Patch here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=39f04a6781f5add1c233a7309d98d84d0a7b99f6

Revision history for this message
Tiffany Little (tslittle) wrote (last edit ):

Galen, I installed these two patches just to tinker around with them, and noticed that when you select a branch in the library settings it only shows the ID as the value instead of the org shortname.

Edited to add: But I was successfully able to set it in the first place, which is great!

Revision history for this message
Galen Charlton (gmc) wrote :

To double-check, is it the case that the Library Settings editor displays a proper OU drop-down to set or update the value, but displays the numeric OU in the grid? If so, that's a deficiency in the Dojo widget code that I think is minor enough to ignore and wait for the Angular Library Settings Editor. The new setting is (I believe) the only one that has an org unit as its value.

Revision history for this message
Galen Charlton (gmc) wrote :

Patches are now included in the pull request branch for bug 1942220.

Revision history for this message
Ruth Frasur Davis (redavis) wrote :

For the sake of Launchpad cleanliness, should this also be signed off on?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.