Optionally remove traditional catalog from menu

[Jeff Davis]

EG 3.9

For those of us who have fully migrated to the Angular catalog, it would be nice to be able to hide the "Staff Catalog (Traditional)" menu option. Not everyone is ready to get rid of the traditional catalog yet, so it makes sense to use a setting for this, as we did for the Angular catalog when it was an "experimental" UI.

[Jeff Davis (jdavis-sitka)]

Working branch user/jeffdavis/lp1980867-hide-trad-cat has a fix:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1980867-hide-trad-cat

This branch adds a new org unit setting, "GUI: Enable Traditional Staff Catalog," which controls whether the old staff catalog appears in the Cataloging menu. The menu item is hidden by default; we could set the setting to "true" at the root org unit if we wanted it to display by default instead.

To test:
[1] Install the branch.
[2] Set the "GUI: Enable Traditional Staff Catalog" library setting to true and clear cache/local storage. The "Staff Catalog (Traditional)" option should appear in the Cataloging menu.
[3] Set the "GUI: Enable Traditional Staff Catalog" library setting to false and clear cache/local storage. The "Staff Catalog (Traditional)" option no longer appears in the Cataloging menu.

The setting should be removed when the traditional catalog is removed. If that ends up happening with the next release, this bug can just be marked Invalid.

[Jeff Davis (jdavis-sitka)]

Force-pushed an update (eg2 template was missing a conditional).

[Gina Monti (gmonti90)]

I, Gina Monti, sign off on this bug. Additionally, you will probably have to log out and back in to see the library setting enabled or disabled reflected in the system.

[Jennifer Weston (jweston)]

Marking confirmed and saying thank you to Jeff for the change and Gina for testing!
Happy to see the signedoff and pullrequest tags on this one!

[Jane Sandberg (sandbergja)]

Agreed, thanks, Jeff and Gina! I've merged this for inclusion in 3.10, along with a small follow-up commit that changes the default behavior when this is not yet set. In the original patch, if this setting was not set, the default case would be *not* to show the menu item. My follow-up changes the default to show the menu item.

In the future, when we feel that a critical mass of the community has migrated to the staff catalog, we could revert my commit, and show the traditional menu item by opt-in only.

[Josh Stompro (u-launchpad-stompro-org)]

Jane, I'm seeing an issue with your follow up, it seems as if it only works in the AngularJS navbar. After this patch is applied, the traditional catalog doesn't show in the Angular navbar unless the setting is set to true.

So on upgrade the traditional catalog option is hidden by default for Angular interfaces.

Josh