Angular holdings template import only imports one template

Bug #1980544 reported by Lindsay Stratton
42
This bug affects 7 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
3.9
Fix Released
Undecided
Unassigned

Bug Description

Version 3.8

If you have a set of holdings templates and export them to a json file, when attempting to import them for another user, only the first template is imported.

This happens in both the 3.8 integrated holdings editor/holdings template editor and the pre-3.8 local admin > holdings template editor interfaces.

Revision history for this message
Lindsay Stratton (lstratton) wrote :

On subsequent tests, importing the file in the pre-3.8 holdings template editor will import all templates, but they are only visible if the holdings template editor is closed and reopened. These templates do not display in the integrated holdings/template editor.

Revision history for this message
Mary Llewellyn (mllewell) wrote :

testing on https://terran-testbox.gapines.org/eg2/en-US/staff/cat,
I can only import one template in the Angular Holdings Editor interface. The whole list is imported in the JS Holdings Template editor, but I needed to log out and back in again to see the list. After that, I was able to see the full list in the Angular Holdings Editor.

tags: added: angular cat-templates
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Jennifer Pringle (jpringle-u) wrote :

I can confirm that what Lindsay and Mary describe is still an issue in 3.9

Revision history for this message
Benjamin Murphy (benjamin.murphy) wrote :

Still an issue in 3.9.1

Revision history for this message
Mary Llewellyn (mllewell) wrote :

I discovered that if you applied a template before doing the export, then that is the one that is exported. But although our required stat cat is part of the template while exporting, it is not included in the template when imported.

Michele Morgan (mmorgan)
tags: added: cat-holdingseditor
Changed in evergreen:
assignee: nobody → Jessica Woolford (jwoolford)
Revision history for this message
Jessica Woolford (jwoolford) wrote :

Fix for this issue at the tip of https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jwoolford/lp1980544-import-all-templates

Added a sign-off for my husband, Adam Woolford, as he wrote this code. It's working on our 3.9.1 test system.

tags: added: pullrequest
Changed in evergreen:
assignee: Jessica Woolford (jwoolford) → nobody
Revision history for this message
Beth Willis (willis-a) wrote :

I tested Jessica's patch on our 3.9.1 server and it works as expected. I was able to import a complete file of holdings templates to my account.

I have tested this code and consent to signing off on it with my name, Beth Willis and my email address, <email address hidden>.

tags: added: signedoff
Michele Morgan (mmorgan)
Changed in evergreen:
assignee: nobody → Michele Morgan (mmorgan)
milestone: none → 3.10.1
Revision history for this message
Michele Morgan (mmorgan) wrote :

Works for me as well!

Pushed to master, rel_3_10 and rel_3_9

Noting that I amended the commit to credit Adam Woolford as the author of the patch.

Thanks Adam, Jessica, and Beth!

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Michele Morgan (mmorgan) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.