OPAC - Should Consistently use "User Name" or "Username"

[Jennifer Pringle]

Evergreen 3.7 - TPAC
Evergreen 3.9 - BOOPAC
Chrome

In the OPAC both "username" and "user name" are used in different spots. We should use one consistently through the whole OPAC.

Currently the following is used in both TPAC and BOOPAC.

Forgot Your Password - user name
Account Preferences -> Personal information - username
Request a Library Card - username

[Jennifer Pringle (jpringle-u)]

Additionally in the patron account it is "OPAC/Staff Client User Name" in the Edit form and "Username" in the patron summary.

[Garry Collum (gcollum)]

"Username" seems to be the more common usage. https://www.merriam-webster.com/dictionary/username

[Gina Monti (gmonti90)]

Hi all! Here's a fix I submitted:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=fd8b620a36e7b15d432379cdf9d872eaa60753ef

I may be missing a few things, but I tried to make it as consistent to 'username' as possible. Works on my testbox!

[Jason Stephenson (jstephenson)]

Thank you, Gina, for sharing your code. It looks good at a quick glance.

We have some guidelines for code contributors when it comes to commit messages that would make it easier for us to review and include your code in Evergreen: https://wiki.evergreen-ils.org/doku.php?id=dev:git#commit_messages

In short, if you could add the Lp bug number to the first line of the commit message and a Signed-off-by line with your name and email address at the bottom, that would be very helpful.

Thanks,
Jason

[Jason Stephenson (jstephenson)]

I also have a question for the community at large: Should this be considered a bug fix and targeted at 3.9 and 3.10, or is this more of a feature-style fix?

It gets blurry with things that could impact strings and translations. At least, I'm not totally clear on what's what any longer.

[Gina Monti (gmonti90)]

Thank you, Jason!

If it was up to me, I say put it out for 3.9 just to get it rolling. That's my opinion. I think I had to do some editing in the Bibliomation OPAC as customization.

[Chrystal Messam (badger85)]

I have tested this code and consent to signing off on it with my name, Chrystal Messam and my email address, <email address hidden>

[Terran McCanna (tmccanna)]

Just noting that this is signed off for testing purposes, but to see Jason's notes in #4 regarding the recommended formatting / signoff in the original commit.

[Gina Monti (gmonti90)]

Sorry Terran! Here's the updated commit:
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=e46f43b68f4fb808747e035fd9085c24ee55e963

[Jason Boyer (jboyer)]

Pushed to master for inclusion in 3.11; thanks Gina and Chrystal!
I'm hesitant to backport it because any existing translations would be broken but if other maintainers have strong feelings about it (or better yet, want to also update the affected translations) I'm open to discussion.