Booking items failing autorenew

[Steve Callender]

Tested in 3.7 but I suspect it's still an issue in current EG

When an item is also listed as a booking resource, the autorenewal process in the triggers will fail to autorenew based on the circulation user not having the VIEW_TRANSACTION permission.

It looks like the trail goes from,

OpenILS/Application/Circ/Circulate.pm > do_checkout sub
my $modify_to_start = $self->booking_adjusted_due_date()

sub booking_adjusted_due_date
my $bookings = $booking_ses->request('open-ils.booking.reservations.filtered_id_list', $self->editor->authtoken

OpenILS/Application/Booking.pm
sub reservation_list_by_filters
return $e->event unless $e->allowed('VIEW_TRANSACTION');

Since there is no staff member doing these checkouts, it uses the auth_internal service to create a session for the patron.

We need to instead either change the way booking is checked for upcoming reservations, or perhaps use the last staff member ID who began the circulation as the user to check.

[Elizabeth Davis (elidavis)]

Can confirm this happens on our production server running 3.7.2.