Order record errors are missing payload

[James Fournie]

Hi -- when loading order records (using Dojo Vandelay interface), many errors such as missing fund code, wrong org unit, etc which might be easily resolved by the user -- aren't displayed to the user, instead a JavaScript Alert pops up that says something along the lines of "Event: ACQ_IMPORT_ERROR -> ". (not sure if it's ACQ_IMPORT_ERROR but something equally vague).

[James Fournie (jfournie)]

The reason for this is here:
https://github.com/evergreen-library-system/Evergreen/blob/422971f7868151bec3aa703ef88af8b1d72679c0/Open-ILS/web/js/dojo/openils/Event.js#L35

In the case of this import error, the server returns the useful information in the payload key of the response, however openils.Event only reports a desc key.

[James Fournie (jfournie)]

Pushed a possible but totally untested fix here: https://github.com/jamesrf/Evergreen/tree/LP1975878

[Jeff Davis (jdavis-sitka)]

I think rather than modifying openils.Event to display the payload (which won't always be desirable), it might be better for Acq/Vandelay to put the relevant information somewhere useful in the first place.

Working branch user/jeffdavis/lp1975878-acq-upload-records-expose-error-msg shows what I have in mind:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1975878-acq-upload-records-expose-error-msg

I'm not sure if that will work as-is. It seems like the event desc is actually supposed to come from ils_events.xml, but ACQ_IMPORT_ERROR isn't defined there, and there are other places where OpenILS::Event->new() is called with an explicit desc param. It's a bit of a mess!

Alternatively, we could use more specific event codes for the four error conditions that cause an ACQ_IMPORT_ERROR event, rather than using the generic ACQ_IMPORT_ERROR.

[Jeff Davis (jdavis-sitka)]

Marking as Won't Fix since the Dojo UI for Load MARC Order Records was superseded in 3.10.