form for editing field doc does not enforce mandatory source and field
Bug #1974457 reported by
Galen Charlton
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Evergreen |
Invalid
|
Low
|
Unassigned | ||
Bug Description
The Angular editor for IDL field doc introduced in bug 1857910 marks and styles the IDL class and IDL field as mandatory. However, the fact that those two comboboxes are for required fields is not propagating to the overall ngForm validation of the fm-editor modal.
As a consequence, if all one does is supply text for the field documentation field, the fm-editor's save button will activate even if a field and class haven't been set yet.
I'm assuming that some digging (and possibly extensive digging) in Angular form validation may be required to resolve this.
Evergreen master
| Changed in evergreen: | |
| importance: | Undecided → Low |
| tags: | added: admin-pages angular |
Revision history for this message
| Galen Charlton (gmc) wrote | #1 |
| Changed in evergreen: | |
| status: | New → Invalid |
To post a comment you must log in.
Unclear when this got fixed, but marking invalid as it now works for me.