Stripe: Add patron info to message

[Terran McCanna]

Evergreen 3.8 / Stripe Payment Intents

There are currently situations (see bug 1965579 for example, but there may be others) where a patron can make a payment through the OPAC, Stripe can successfully charge them, but then when Stripe sends the info back to Evergreen it hits an error and Evergreen does not credit the patron account.

These payments show up on Stripe's report, but there is nothing on that report that can be used to identify which patron made the payment, so no way for staff to correct the patron's account.

In PINES we are adding the patron's database ID to the info that we send to Stripe so that it will appear in Stripe's Description field as a way library staff can reconcile the payment with the correct account. Patch coming momentarily in case it is something that would be useful to other libraries.

[Terran McCanna (tmccanna)]

Patch for consideration: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1969994_stripe_patron_id

[Terran McCanna (tmccanna)]

No, that's not getting the right ID. Oops.

[Terran McCanna (tmccanna)]

Second commit pushed to same branch to use the patron id rather than the card id:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1969994_stripe_patron_id

[Terran McCanna (tmccanna)]

Note that we've had this working in production in PINES for 3 months.

[Garry Collum (gcollum)]

Set up stripe in a vm with my test keys to test. This is nice. A signed-off branch is at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/lp1969994_strip_patron_id-signoff

Oops! Sorry about the typo in the in the signoff path.

[Josh Stompro (u-launchpad-stompro-org)]

Hello, I also tested this.

I've tested this on https://terran-master.gapines.org.

Marked two items for user 99999329662 lost. User DB ID: 18

Received a screenshot from Stripe dashboard that showed "User Database ID: 18". So it appears to be working as intended.

Josh

[Jason Boyer (jboyer)]

Pushed a squashed commit and relnote to master/3_10, rel_3_9, and rel_3_8. Thanks Terran, Garry, and Josh!