Removing items from copy buckets leads to drone exhaustion

[Jessica Woolford]

3.6.5, and presumably later releases

1. Add a bunch of items to an item bucket.
2. Select all items.
3. Actions > Remove selected items from bucket.

Removing multiple items from an item buckets leads to a separate container.copy_bucket_item.delete calls. If the number of items removed exceeds the number of max_children for open-ils.actor, you'll see "no children available" warnings in the logs.

(Wording here borrowed heavily from bug #1949910 since it is a similar issue.)

[Jessica Woolford (jwoolford)]

Here's a patch that works in a local test environment. Borrowed heavily from Bill's work on bug 1913458, definitely needs some more experienced eyes on it!

(editing to add the the patch now uses the batch method from the ticket linked above for removing AND adding items from item buckets)

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jwoolford/lp1968082-batch-method-item-buckets

[Jane Sandberg (sandbergja)]

Thanks, Jessica. This works well, and definitely takes care of those "Could not launch a new child as 15 children were already running" in osrfsys.log.

Could you please add your signoff to your commit? And then I'm very happy to signoff myself.

[Jessica Woolford (jwoolford)]

Thank you, Jane! I've added my sign off to the original commit.

Also you posted your comment on my birthday, which was a nice surprise for me! :)

[Jane Sandberg (sandbergja)]

Happy belated birthday, Jessica!!! My signoff is at user/sandbergja/lp1968082-batch-method-item-buckets-signoff

[Galen Charlton (gmc)]

Pushed all the way down to rel_3_7, along with two follow-ups:

- whitespace cleanup
- displaying the progress bar during a batch add/delete to discourage the user from attempting to interact with the page while the update is occurring

I was able to remove several thousands items from a bucket with neither muss nor fuss.

Thanks, Jessica and Jane! Also, happy birthday, Jessica!