Angular Holdings editor not honoring required stat cat

[Mary Llewellyn]

Webclient 3.8 Angular Holdings editor

What I expected:

We have a required copy statistical category for our state's circulation codes. If an item is created without setting a value for this stat cat, I expect the Apply/Save/Exit button to be inactive, and that there be a visual cue that the stat cat is required.

What happened:
I left the stat cat as unset and was still able to save and exit the item.
No visual cue was apparent.

[Mary Llewellyn (mllewell)]

When we include the stat cat in a template and apply it, the other fields (shelving location and circ mod) in the template turn green and a red asterisk appears after the field name. While the value for the stat cat is filled in, it does not turn green and no asterisk appears.

[Mary Llewellyn (mllewell)]

When I look at the item in the Angualar JS Holdings Editor, the stat cat field was not filled in at all. This reflects the behavior of the applied template not turning the field green in the Angular Holdings Editor.

[Jennifer Pringle (jpringle-u)]

Confirmed you can save an item without entering the required stat cat in 3.9. There is also no indication in the holdings edotpr that the stat cat is required.

[Bill Erickson (berick)]

Here's a branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1965448-volcopy-required-stat-cats

The branch also removes 'pending changes' alerts that appear when navigating between holdings editor tabs. Otherwise, you can end up in scenarios where it warns of pending changes, but you cannot save them because save is disabled due to lack of a required value.

Warning for pending changes when navigating between tabs should never have been implemented, anyway, since no changes are lost when that happens. Warnings will still appear if the user attempts to navigate away.

[Galen Charlton (gmc)]

Works for me. Pushed to master, rel_3_9, and rel_3_8. Thanks, Bill!