OPAC post-hold "continue" link leads to raw XML

[Jeremiah Miller]

Somewhat esoteric, but...

If an OPAC user has followed a link from an RSS feed to get to a record, and places a hold on that title, the link they are given to "continue" should lead them back to that same record. But the link appears to be an odd mix between the unapi-based url that they'd come from, and a regular link. As a result they do not go back to the record, they get a raw XML page listing the available formats for that unapi call.

Example...

Here is the RSS feed in question:
https://libweb.cityofalbany.net/opac/extras/feed/bookbag/rss2-full/1114029

Here is the link one follows into the OPAC when clicking on one of the titles in the feedL
https://libweb.cityofalbany.net/opac/extras//unapi?id=tag:open-ils.org,2022-03-03:biblio-record_entry/89456/LINN&format=opac

Here is the address one is on, during the process of placing that title on hold:
https://libweb.cityofalbany.net/eg/opac/place_hold?hold_source_page=%2Fopac%2Fextras%2F%2Funapi%2Fopac%2Frecord%2F89456;hold_target=89456;hold_type=T

After sucessfully placing the title on hold, this is the link that is given to go back to the record:
https://libweb.cityofalbany.net/opac/extras//unapi/opac/record/89456

Note that this link (and the hold source page referenced in the url) is missing much of what it needs to work properly if using an unapi call. It should look like this:
https://libweb.cityofalbany.net/opac/extras//unapi?id=tag:open-ils.org,2022-03-03:biblio-record_entry/89456/LINN&format=opac

Or at least an equivalent that tells it to open the bib record, using format=opac.

Or perhaps it should recognize it doesn't have what it needs to construct an unapi link, and should just return a normal link like this:
https://libweb.cityofalbany.net/eg/opac/record/89456

Either way, I'm pretty sure the intended result is not the XML list of available output formats.

EG 3.7.1 on Debian buster

[Jeremiah Miller (jeremym-t)]

FWIW, this came up with a selfcheck product we are testing. It can include RSS feeds (of new titles, staff selections, or whatever) in the "waiting to be used" display, and open them up in a kiosk-mode browser.

Works great, including logging in and placing the hold. But then... full screen of XML, definitely confusing for the average patron.

[Garry Collum (gcollum)]

Confirmed in Boopac in current master (3.9.0ish)