Setting to hide the "Clear These Holds" button

[Dan Briem]

Wishlist: org unit setting to hide the Clear These Holds button in the Holds Shelf interface.

This button runs the clear hold shelf process on all of the clearable holds. This includes potentially misplaced copies that are not physically on the holds shelf (for whatever reason). Their status will change according to the Clear Hold Shelf Status setting and, since they are no longer on the list, they can fall through the cracks and remain in an inaccurate status.

Our system trains staff not to use this button, but we would prefer if there was a setting to hide it.

[Dan Briem (dbriem)]

Branch for testing: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbriem/lp1961534_hide_clear_these_holds_button

[Jessica Woolford (jwoolford)]

Works as advertised! Button shows on a workstation for an org unit where the setting is not enabled, and doesn't show on a workstation for an org unit that has it enabled. As someone who just re-wrote some documentation to address this issue, I like this very much!

I consent to sign off on this code with my name, Jessica Woolford, and email <email address hidden>.

[Michele Morgan (mmorgan)]

I reviewed this for inclusion in main, but saw Clear These Holds button appearing intermittently when the library setting was set to hide it along with "hidden is not a function" console errors.

I cherry-picked Dan's branch against main, added Jessica's signoff and added an additional commit to address the errors. Here's a link to the working branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp1961534_hide_clear_these_holds_button_update

user/mmorgan/lp1961534_hide_clear_these_holds_button_update

I'm removing the signedoff tag because of the additional commit, but hope it can be reviewed for 3.13beta.

[Michele Morgan (mmorgan)]

Setting the tags right - this should have a pullrequest and not a signedoff at this point (Thanks Josh!).