New Holdings Editor Ignores "Default Classification Scheme" Library Setting

[Jennifer Pringle]

Evergreen 3.8
Chrome

The classification field in the Holdings Editor is blank in the new holdings editor until you make changes to the Preferences. Evergreen should use the "Default Classification Scheme" library setting unless staff set something different in their Holdings Editor Preferences/

The Default Classification in Preferences always comes up as Generic until set. This should also follow the "Default Classification Scheme" library setting.

[Elaine Hardy (ehardy)]

We are also seeing intermittent issues where items won't save if a classification scheme isn't chosen in the holdings editor. Even with a "Default Classification Scheme" chosen in library settings

[Erica Rohlfs (erohlfs)]

Confirming that I see this behavior in version 3.8. If the Library Setting "Default Classification Scheme" is unset/null, then I see the default "generic" classification in the holdings editor. Once I set a value in the library setting, log out, log back in, and go back into the holding editor, the classification field is blank.

[Lindsay Stratton (lstratton)]

I just tested in 3.8, with library setting default classification set to 2-Dewey, and no default set in the Holdings Editor > Preferences.

On clicking Add Holdings, the Classification field was blank. Leaving the classification blank, I added a barcode and clicked Apply All and Save. The volume record saved, and Dewey populated the classification field. I was able to continue to create the item attributes and save the holdings records as expected.

However. Using the non-Angular Holdings Editor, as accessed via Item Status > Add (or Edit) Call Numbers / Call Numbers and Items, the classification displays as Generic.

[Michele Morgan (mmorgan)]

I was not able to reproduce this on a master-ish Concerto test system, but did see the issue with a 3.9 system with production data.

Looking in the database at the org unit setting cat.default_classification_scheme, values for the settings are stored as:

"1"
"2"
"3"

On the Concerto test system, those values are stored as:

1
2
3

When I removed the quotes from the values in the production data, it appeared to solve the issue. So it looks like the quotes in the actor.org_unit_setting.value field are causing breakage.

[Michele Morgan (mmorgan)]

Here's a working branch that removes the quotes from the retrieved setting.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp1960885_angular_holding_default_classification

user/mmorgan/lp1960885_angular_holding_default_classification

Note that the Angularized Library Settings Editor (3.10) stores the library setting without quotes.

[Kate Coleman (katecoleman)]

Tested on MOBIUS Test Server 2. Does seem to now work as intended.

Workflow:
Checked that adding item defaulted to Generic classification scheme. It did.
In Library Settings Editor, I changed the default classification to LC.
Added a holding and it did use the new default classification of LC.

A step further:

Went into preferences in Holdings editor and changed default to Dewey.
Added a holding on a different title and Dewey came up as default.
Went to preferences again and blanked out the Default Classification field (which changes default back to Generic)
Went to add another holding classification scheme defaulted back to the Library Settings default of LC.

[Terran McCanna (tmccanna)]

Kate, are you ready to sign off? If so, can you please add the sign off text as described here? https://wiki.evergreen-ils.org/doku.php?id=dev:bug_squashing#testing_bug_fixes

Thanks!

[Carol Witt (carolwitt)]

I was able to duplicate Kate's results.

I have tested this code and consent to signing off on it with my name, Carol Witt and my email address, <email address hidden>.

[Jason Boyer (jboyer)]

Looks good, pushed to main and rel_3_11 for the next 3.11 release. Thanks everyone!