Item alert and note creation silently fails in unified holdings/attribute editor

[Elaine Hardy]

In 3.8

You cannot add item alert messages or item notes to an item in the process of creating it, as you could in previous version when using the unified holdings and item attributes display.

Attempting to add item alerts or notes in the attributes editor silently fails and locks the screen. Clicking on the item alerts or item notes button fails to open the interface and the screen locks so that you can't scroll. While you can make edits to those attributes in screen view, you can't scroll down to save the item(s) and have to close the editor tab to exit. Losing any edits you have already made.

The console message is:

main.83e1c293da137dcd2dd9.js:1 ERROR TypeError: Cannot read properties of undefined (reading 'barcode')
    at P (5.363c283a262b34e0b274.js:1:10331)
    at ii (main.83e1c293da137dcd2dd9.js:1:298711)
    at ni (main.83e1c293da137dcd2dd9.js:1:297286)
    at main.83e1c293da137dcd2dd9.js:1:297713
    at ni (main.83e1c293da137dcd2dd9.js:1:297738)
    at Ri (main.83e1c293da137dcd2dd9.js:1:305708)
    at hs.detectChanges (main.83e1c293da137dcd2dd9.js:1:311637)
    at tick (main.83e1c293da137dcd2dd9.js:1:388988)
    at main.83e1c293da137dcd2dd9.js:1:387435
    at l.invoke (polyfills.9b26e9b6c6d2049cc2b1.js:1:7302)

If you create the item first by clicking on Apply All & save, you can add alert messages and item notes.

[Elaine Hardy (ehardy)]

May be related to https://bugs.launchpad.net/evergreen/+bug/1956986

[Jennifer Pringle (jpringle-u)]

When I click "Apply All, Save & Exit" the alert or item note interface (whichever I tried to use) appears for a second while the holdings editor is closing. See attached screenshot.

[Mary Llewellyn (mllewell)]

The only reason it doesn't fail in the non-unified editor is that you have to click on Apply All & Save when you move from the Holdings tab to the Item Attributes tab. I tried going directly to the Item Attribute tab first to add an Item Note, but experienced the inability to add the note with the screen locking up.

[Elaine Hardy (ehardy)]

Yes, that is currently our work around for adding items to new items -- not use the unified editor to create the item first.

[Christine Burns (christine-burns)]

persists in 3.9

[Bill Erickson (berick)]

Here's a fix:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1959716-volcopy-new-item-alerts-notes

[Galen Charlton (gmc)]

Works for me. Pushed to master, rel_3_9, and rel_3_8 along with a follow-up to extend the fix to include item tags. Thanks, Bill!

[Bill Erickson (berick)]

Regression from this bug fixed in bug #1955065

[Galen Charlton (gmc)]

And a regression introduced by my follow-up fixed in bug 1981095