Angular Login Page fails to show offline message

[Terran McCanna]

Evergreen 3.8:

If you have unprocessed offline transactions waiting for upload, the AngularJS login page displays the message properly, but the Angular login page does not.

The browser console in the Angular login page has this error:

open-ils.pcrud.search.i18n_l failed! stat=401 msg=open-ils.pcrud: permacrud received a bad auth token: (null)

[Terran McCanna (tmccanna)]

See also: https://bugs.launchpad.net/evergreen/+bug/1835128

[Bill Erickson (berick)]

Here's a fix:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1958258-ang-login-pending-xacts

NOTE: this is built atop the latest branch for bug #1904036 since that code introduces a new offline data service. This branch will have to be merged after/with bug #1904036.

[Terran McCanna (tmccanna)]

I tested this on a server that had bug #1904036 applied and it worked great.

I consent to signing off with this under my name, Terran McCanna, and my email, <email address hidden> (with the caveat that it can't be merged to master until after #1904036 is ready).

[Bill Erickson (berick)]

Setting milestone to 3.next since bug #1904036 will not make it into 3.9.

[Bill Erickson (berick)]

Note if this becomes a bigger issue, the relevant parts of bug #1904036 could be extracted for use by this bug.

[Galen Charlton (gmc)]

Pushed down to rel_3_10. Thanks, Bill and Terran!