Editing a note changes depth if standing penalty has depth setting

[Terran McCanna]

In 3.8: If you set the org depth for the "Note, no blocks" / SILENT_NOTE standing penalty it will set the default org depth correctly, but if you save the org depth for that note to a different level and then edit it, it will revert to the default.

To recreate:

1) Under Admin > Local Admin > Standing Penalties...
2) Set SILENT_NOTE to have 0 as the org depth so that new notes will default to the consortium level
3) Go to a patron account and create a Note - notice that it defaults to the consortium level. Select the system level instead and save it.
4) Verify that the Location column reflects the system level Location setting correctly.
5) Edit the note and notice that the depth dropdown has reset itself to the consortium level.

Ideally, the modal would load the depth/location setting that had previously been saved, and then give the option to change it.

[Erica Rohlfs (erohlfs)]

Confirming in version 3.8. When I click Edit Note and am taken back into the Create or Edit Note screen, the Depth dropdown menu has reset to "Everywhere" - if the user doesn't catch this, the note does rescope to CON.