System level workstation displays only consortia owned shelving locations

[Elaine Hardy]

For 3.8

When a workstation is registered at the system level (STATELIB, for example), the only shelving locations in the dropdown menu in the holdings editor are consortia owned and not the system shelving locations as in 3,6 and before.

See attachment for screenshots.

[Jennifer Pringle (jpringle-u)]

I haven't been able to confirm exactly what's described but I am seeing weirdness.

On the 3.8 community server I created a shelving location for SL1. SL1 is a Sub Library of BR1 which is a branch. (System level org units on the community test server aren't permitted to have holdings).

When I look at the shelving location list in the Holdings Editor signed in at BR1 I can see shelving locations for BR1, SYS1, and CONS but my SL1 shelving location doesn't appear.

[Michele Morgan (mmorgan)]

Marking this Confirmed.

In the pre 3.8 holdings editor, a staff user could see and apply any shelving locations owned by their workstation location, it's ancestors and descendants.

In the angular holdings editor, a logged in staff user can only see shelving locations at their workstation location and above, but only as far as their permission depth will allow.

As examples, in a 3.8 Concerto system, a Cataloger with BR1 working location has the CREATE_COPY permission at the System level.

- When logged into a SYS1 workstation, they see locations owned by SYS1

- When logged into a BR1 workstation, they see locations owned by SYS1 and BR1

Prior to 3.8:

- When logged into a SYS1 workstation, they would see locations owned by CONS, SYS1, BR1, BR2, SL1

- When logged into a BR1 workstation, they would see locations owned by CONS, SYS1, BR1, SL1

From Elaine's original description, I am guessing that the staff user has Consortium level permissions, and that there are no shelving locations owned by STATELIB, but many owned by STATELIB's descendants. So for this configuration, only the CONS shelving locations are displaying.

[Bill Erickson (berick)]

Here's a branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1956627-volcopy-locations-full-org-path

[Katie Greenleaf Martin (kgmspark)]

Testing this patch at https://terran-testbox.gapines.org/
Logged in as SL1 workstation, I can see shelving locations for: CONS, SYS1, BR1, SL1 (had to create a location for SL1 first, there weren't any)
Logged in as BR1 workstation, I can see shelving locations for: CONS, SYS1, BR1, SL1
Logged in as SYS1 workstation, I can see shelving locations for: CONS, SYS1, BR1, BR2, SL1
Logged in as SYS2 workstation, I can see shelving locations for: CONS, SYS2, BR3, BR4, BM1
Logged in as BM1 workstation, I can see shelving locations for: CONS, SYS2, BR3, BM1

Notes: only tested on one bib - TCN 210 ; created an item at BM1 for a SYS2 owned location and didn't have any errors but didn't actually create an item anywhere else, just verified that the locations appear.

Seems to be working as advertised :)

[Carol Witt (carolwitt)]

I've tested this patch at https://terran-testbox.gapines.org/

Workstation Login (TCN # Checked): Shelving Locations Viewed

BR4 (TCN 223): BR3, SYS2, BR4, CONS, BM1
SL1 (TCN 21): BR1, SYS1, SL1, CONS
BR2 (TCN 152): BR2, SYS1, CONS
BR3 (TCN 65): BR3, SYS2, CONS, BM1

I added a few test items with shelving locations that differed from the login without any issues. I agree with Katie that it's working as it should.

I have tested this code and consent to signing off on it with my name, Carol Witt and my email address, <email address hidden>.

[Elaine Hardy (ehardy)]

I created a system level workstation SYS1-JEH test and was also able to see shelving locations for CONS, SYS1, BR1, and BR2.

Add my voice to working as expected.

[Bill Erickson (berick)]

Thanks for all the feedback. Merged to 3.8 and up w/ Carol's sign off.