Add admin interfaces for fiscal calendars and fiscal years

[Galen Charlton]

Evergreen has had the acq.fiscal_year and acq.fiscal_calendar tables for years, but without administrative interfaces. They should be added, as a couple places do actually query acq.fiscal_year:

- the Dojo Load MARC Order Records form, via open-ils.acq.org_unit.current_fiscal_year
- the fiscal year selector in the branch for bug 1929749

There are a number of other bugs reported about fiscal periods in Evergreen, but having an administrative interface might inspire additional progress on them.

[Jennifer Pringle (jpringle-u)]

https://bugs.launchpad.net/evergreen/+bug/1486213 is a related wishlist bug for having a setting that allows libraries to specify their fiscal year. It includes discussion about how libraries would like to see the fiscal year display when it spans two calendar years.

[Tiffany Little (tslittle)]

Pullrequest fix here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tlittle/LP1956510_acqadmin_fy

This adds tabs for Fiscal Years and Fiscal Calendars to the already-existing "Fund Administration" area of acq admin. Both interfaces are controlled by the existing ADMIN_ACQ_FISCAL_YEAR permission, which by default is already given to the Acquisitions Administrator perm profile. If you log in with a profile that doesn't have the perm, the create boxes are greyed out and inaccessible.

[Tiffany Little (tslittle)]

I'm going to change this from Wishlist to Medium priority, because IMO it's a reasonable fix for bug 2021992.

[Galen Charlton (gmc)]

Does the thing, so I've pushed a signoff branch to user/gmcharlt/lp1956510_signoff along with two supplemental patches:

- marking fields required in the IDL
- adding grid settings

Tiffany, please feel free to test and cross-signoff.

I agree that it makes sense to backport this.

[Tiffany Little (tslittle)]

I'm going to remove my pullrequest, because this was looked over at today's AIG meeting. There was general agreement that this would fit better *not* in the Fund Administration area, but in its own spot in Acquisitions Administration. I'll work on that and will provide an updated branch.

[Galen Charlton (gmc)]

OK. My IDL update patch should work as is for a reworked branch; the automatic grid settings names may be slightly different.

[Tiffany Little (tslittle)]

New branch here for testing and review: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tlittle/LP1956510_AdminUI_acqfyfc

[Christine Morgan (cmorgan-z)]

Testing on bugsquash.mobiusconsortium.org in Chrome in an incognito window.

Tested using RPLS-HDPL and the admin and br2jroberts logins.

- I created two fiscal calendars, one for July - June and one for Jan - Dec.
- I then created a 2024 fiscal year for each fiscal calendar, selecting the appropriate fiscal calendar from the Calendar dropdown.

- I tried deleting one of the fiscal calendars that I had created. There was a message in the confirmation box, "Are you sure you want to delete the selected rows? This will also delete any data depending on the rows deleted."
- I clicked Confirm and the associated fiscal year entry was deleted, which I think is appropriate.

That all worked well.

- I then went to the Load MARC Order Records screen to see if I could select the fiscal years I had added but those years were not listed in the Year dropdown. I could only select 2023.

- I then tried adding a new fund. There wasn't a dropdown for Year (which I think there should be) so I entered 2024 in the Year box and filled in the remaining required fields.
- I clicked Save and received a success message but the fund was not created.
- I tried creating another fund using 2023 in the Year box and that fund was created and displayed in the grid.

So it doesn't look like the Load MARC Order Records and New Fund interfaces are seeing the fiscal years created in the new interface.

[Terran McCanna (tmccanna)]

Adding needswork as per comment 8

[Terran McCanna (tmccanna)]

Removing milestones for the time being since it looks like this one needs a bit more work.

[Tiffany Little (tslittle)]

I think this one actually just needs a release note as an explanation. I went and investigated after Christine's comment and I think it's working fine (pending someone else's signoff, of course).

I walked through the patch using Christine's testing notes, then I went to look at the selector on Load MARC Order Records. Turns out that when it's looking for what fiscal years to grab, it's actually looking at the Fiscal Calendar that's specified in the org unit, which by default is "Default." So if you create a new fiscal calendar of July-Jun like in Christine's example and don't change the Fiscal Year on the org unit, it won't see any new fiscal years you create.

Testing on a BR1 workstation, I created a fiscal calendar for Jul-Jun, then two associated 2024 and 2025 fiscal years. Then I changed the Fiscal Calendar for BR1 to Jul-Jun, ran autogen, and now I see the 2024 and 2025 fiscal years in the Load MARC Order Records dropdown.

Re: the fiscal years not being shown in funds, that would be (and is) a different bug: bug 2021996.

FYI: This is installed on my test server as of today (11/13/23) for testing.

[Tiffany Little (tslittle)]

Release note added as the top commit to the branch.

[Christine Morgan (cmorgan-z)]

Testing again on tiffany-main.gapines.org.

Logged in as BR1 (br1lfarrell) with the fiscal calendar (Jan-Dec) that Tiffany specified in the org unit, I was able to see the 2024 and 2025 fiscal years in the Load MARC Order Records year dropdown.

I added a 2026 fiscal year or the Jan-Dec calendar year and that also displayed in the Load MARC Order Records year dropdown.

I changed the 2026 fiscal year to have a July-June calendar year and 2026 no longer displayed in the Load MARC Order Records year dropdown.

So I think this looks good.

Thanks for a much needed interface Tiffany!

I have tested this code and consent to signing off on it with my name,
Christine Morgan and my email address,
<email address hidden>.

[Terran McCanna (tmccanna)]

(Changed back to Wishlist since it's a new feature.)

[Terran McCanna (tmccanna)]

Because this is a new feature *and* it requires upgrade scripts, the 3.12 Release Team opted not to backport it. However, libraries running 3.10 or 3.11 may be able to apply it locally.